Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976103003: Migrate dart2js stubs for dart:io (Closed)

Created:
4 years, 7 months ago by vsm
Modified:
4 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate dart2js stubs for dart:io Modifies tests to use our SDK. Didn't prune io dependences to make sure the stubs above work. :-) R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8bdf6b2523fcfc8eced5f5a05194370b7c2e9ec7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19328 lines, -88 lines) Patch
M test/codegen_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A tool/input_sdk/lib/io/bytes_builder.dart View 1 chunk +206 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/common.dart View 1 chunk +124 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/crypto.dart View 1 chunk +448 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/data_transformer.dart View 1 chunk +587 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/directory.dart View 1 chunk +313 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/directory_impl.dart View 1 chunk +428 lines, -0 lines 0 comments Download
A + tool/input_sdk/lib/io/eventhandler.dart View 1 chunk +5 lines, -8 lines 0 comments Download
A tool/input_sdk/lib/io/file.dart View 1 chunk +885 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/file_impl.dart View 1 chunk +1025 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/file_system_entity.dart View 1 chunk +841 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/http.dart View 1 chunk +2033 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/http_date.dart View 1 chunk +315 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/http_headers.dart View 1 chunk +999 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/http_impl.dart View 1 chunk +2890 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/http_parser.dart View 1 chunk +1072 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/http_session.dart View 1 chunk +174 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/io.dart View 1 chunk +243 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/io_resource_info.dart View 1 chunk +283 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/io_service.dart View 1 chunk +51 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/io_sink.dart View 1 chunk +309 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/io_sources.gypi View 1 chunk +42 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/link.dart View 1 chunk +305 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/platform.dart View 1 chunk +210 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/platform_impl.dart View 1 chunk +121 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/process.dart View 1 chunk +581 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/secure_server_socket.dart View 1 chunk +295 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/secure_socket.dart View 1 chunk +1263 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/security_context.dart View 1 chunk +267 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/service_object.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/socket.dart View 1 chunk +738 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/stdio.dart View 1 chunk +361 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/string_transformer.dart View 1 chunk +130 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/websocket.dart View 1 chunk +410 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/io/websocket_impl.dart View 1 chunk +1258 lines, -0 lines 0 comments Download
M tool/input_sdk/patch/io_patch.dart View 17 chunks +83 lines, -76 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 7 months ago (2016-05-13 23:27:21 UTC) #3
Jennifer Messerly
lgtm
4 years, 7 months ago (2016-05-13 23:31:26 UTC) #4
vsm
4 years, 7 months ago (2016-05-16 15:23:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8bdf6b2523fcfc8eced5f5a05194370b7c2e9ec7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698