Subzero, MIPS32: Implement logical instructions ashr, lshr, shl

Subzero, MIPS32: Implement logical instructions ashr, lshr, shl

This patch adds support for logical operations ashr, lshr and shl.

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c2ee36a65cb3ea176210301bb73dfda97ef229c9

[obucinac, 2016-05-13 18:08:53]

Description was changed from

==========
Subzero, MIPS32: Implement logical instructions ashr, lshr, shl

This patch adds support for logical operations ashr, lshr and shl.









BUG=
==========

to

==========
Subzero, MIPS32: Implement logical instructions ashr, lshr, shl

This patch adds support for logical operations ashr, lshr and shl.
==========

[obucinac, 2016-05-13 18:08:53]

obucinac@gmail.com changed reviewers:
+ stichnot@chromium.org

[obucinac, 2016-05-16 15:36:44]

obucinac@gmail.com changed reviewers:
+ sagar.thakur@imgtec.com

[Jim Stichnoth, 2016-05-17 19:02:10]

I just noticed this CL in my queue, and I'll review it shortly.

Be sure to "Publish+Mail Comments ('m')" when a CL is ready for review
(including making new changes / uploading new patchsets) so that a notification
is mailed to reviewers.

[Jim Stichnoth, 2016-05-17 20:15:00]

lgtm

https://codereview.chromium.org/1975283002/diff/1/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/1975283002/diff/1/src/IceInstMIPS32.h#newcode149
src/IceInstMIPS32.h:149: Srl,
Just curious - I didn't see any actual uses of Srl, wondering if this is just
for aesthetic completeness, or for future use.

[Jim Stichnoth, 2016-05-17 20:16:05]

Description was changed from

==========
Subzero, MIPS32: Implement logical instructions ashr, lshr, shl

This patch adds support for logical operations ashr, lshr and shl.
==========

to

==========
Subzero, MIPS32: Implement logical instructions ashr, lshr, shl

This patch adds support for logical operations ashr, lshr and shl.

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-05-17 20:16:07]

Committed patchset #1 (id:1) manually as
c2ee36a65cb3ea176210301bb73dfda97ef229c9 (presubmit successful).