Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1974783002: Revert of Move SkTypeface to sk_sp. (Closed)

Created:
4 years, 7 months ago by scroggo
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move SkTypeface to sk_sp. (patchset #5 id:80001 of https://codereview.chromium.org/1933393002/ ) Reason for revert: fontmgr_iterAndroid failing to draw emoji. E.g. https://gold.skia.org/search2?blame=6296da736fbf40aae881650c239420f64e576c3f&unt=true&head=true&query=source_type%3Dgm Original issue's description: > Move SkTypeface to sk_sp. > > Committed: https://skia.googlesource.com/skia/+/6296da736fbf40aae881650c239420f64e576c3f TBR=reed@google.com,fmalita@chromium.org,tomhudson@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9a9a7b29e5e5916a7b6453cd124ca437f14b9da4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -349 lines) Patch
M bench/CmapBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/SkGlyphCacheBench.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M bench/TextBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/TextBlobBench.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M dm/DM.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fuzz/FilterFuzz.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M gm/coloremoji.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/colortype.cpp View 3 chunks +12 lines, -5 lines 0 comments Download
M gm/colortypexfermode.cpp View 3 chunks +13 lines, -6 lines 0 comments Download
M gm/dftext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/fontcache.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M gm/fontmgr.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M gm/fontscalerdistortable.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M gm/gammatext.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M gm/mixedtextblobs.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/pdf_never_embed.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M gm/poly2poly.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/textblob.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/textblobmixedsizes.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M gm/textblobrandomfont.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
M gm/typeface.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M gm/variedtext.cpp View 5 chunks +18 lines, -10 lines 0 comments Download
M gm/verttext2.cpp View 3 chunks +15 lines, -7 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkFont.h View 2 chunks +9 lines, -9 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +1 line, -3 lines 0 comments Download
M include/core/SkTypeface.h View 3 chunks +36 lines, -61 lines 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 chunk +4 lines, -7 lines 0 comments Download
M public.bzl View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/ClockFaceView.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/SampleAnimatedText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M samplecode/SampleFontScalerTest.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M samplecode/SampleSlides.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleXfermodesBlur.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M src/animator/SkDrawPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkPaintPart.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkFont.cpp View 5 chunks +22 lines, -13 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkTextBlob.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkTypeface.cpp View 6 chunks +39 lines, -38 lines 0 comments Download
M src/core/SkTypefacePriv.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/fonts/SkGScalerContext.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/fonts/SkGScalerContext.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M src/fonts/SkRandomScalerContext.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/fonts/SkRandomScalerContext.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_android.cpp View 2 chunks +4 lines, -1 line 1 comment Download
M src/svg/SkSVGDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkLua.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/utils/SkWhitelistTypefaces.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M tests/FontHostStreamTest.cpp View 2 chunks +13 lines, -6 lines 0 comments Download
M tests/FontHostTest.cpp View 6 chunks +14 lines, -13 lines 0 comments Download
M tests/FontMgrTest.cpp View 4 chunks +7 lines, -5 lines 0 comments Download
M tests/FontObjTest.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PaintTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/TextBlobTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/TypefaceTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/Resources.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/Resources.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tools/sk_tool_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/sk_tool_utils.cpp View 3 chunks +12 lines, -8 lines 0 comments Download
M tools/sk_tool_utils_font.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M tools/using_skia_and_harfbuzz.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scroggo
Created Revert of Move SkTypeface to sk_sp.
4 years, 7 months ago (2016-05-12 13:22:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974783002/1
4 years, 7 months ago (2016-05-12 13:22:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9a9a7b29e5e5916a7b6453cd124ca437f14b9da4
4 years, 7 months ago (2016-05-12 13:22:34 UTC) #4
tomhudson
lgtm
4 years, 7 months ago (2016-05-12 13:26:05 UTC) #5
tomhudson
4 years, 7 months ago (2016-05-12 13:29:39 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1974783002/diff/1/src/ports/SkFontMgr_android...
File src/ports/SkFontMgr_android.cpp (left):

https://codereview.chromium.org/1974783002/diff/1/src/ports/SkFontMgr_android...
src/ports/SkFontMgr_android.cpp:389: paint.textToGlyphs(&character,
sizeof(character), &glyphID);
Looks like we accidentally omitted the return statement here?

Powered by Google App Engine
This is Rietveld 408576698