tests/PictureTest.cpp - Issue 1974783002: Revert of Move SkTypeface to sk_sp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureTest.cpp

Issue 1974783002: Revert of Move SkTypeface to sk_sp. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PictureTest.cpp

diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp

index 832a80f438e7dfb8535223ac652e485ef143061b..9e36d841df4535a6497e6edb057e72d4db5b7a38 100644

--- a/tests/PictureTest.cpp

+++ b/tests/PictureTest.cpp

@@ -1177,7 +1177,7 @@

SkPictureRecorder recorder;

SkCanvas* canvas = recorder.beginRecording(10, 10);

SkPaint paint;

- paint.setTypeface(SkTypeface::MakeFromName("Arial", SkTypeface::kItalic));

+ paint.setTypeface(SkTypeface::CreateFromName("Arial", SkTypeface::kItalic));

canvas->drawText("Q", 1, 0, 10, paint);

sk_sp<SkPicture> picture(recorder.finishRecordingAsPicture());

REPORTER_ASSERT(reporter, picture->hasText());