tests/PDFPrimitivesTest.cpp - Issue 1974783002: Revert of Move SkTypeface to sk_sp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PDFPrimitivesTest.cpp

Issue 1974783002: Revert of Move SkTypeface to sk_sp. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PDFPrimitivesTest.cpp

diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp

index 07ddabc9126d18f2a0df71888b251cc477b2ad80..58dd773fb84b36fda66d905289128c7bca025b38 100644

--- a/tests/PDFPrimitivesTest.cpp

+++ b/tests/PDFPrimitivesTest.cpp

@@ -430,7 +430,7 @@

SkPDFCanon canon;

const char resource[] = "fonts/Roboto2-Regular_NoEmbed.ttf";

- sk_sp<SkTypeface> noEmbedTypeface(MakeResourceAsTypeface(resource));

+ sk_sp<SkTypeface> noEmbedTypeface(GetResourceAsTypeface(resource));

if (noEmbedTypeface) {

REPORTER_ASSERT(reporter,

!SkPDFFont::CanEmbedTypeface(noEmbedTypeface.get(), &canon));