Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19744007: Create a public API around webkit::ppapi::PluginInstance and use it in chrome. After this, webkit/p… (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Create a public API around webkit::ppapi::PluginInstance and use it in chrome. After this, webkit/plugins/ppapi can move to content/renderer/ppapi BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213481

Patch Set 1 #

Total comments: 2

Patch Set 2 : less casting and fix linux build #

Total comments: 2

Patch Set 3 : review comments and undo checkdeps change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+856 lines, -4334 lines) Patch
M chrome/renderer/pepper/pepper_flash_menu_host.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_pdf_host.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 2 5 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/media/crypto/content_decryption_module_factory.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_audio_input_host.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_audio_input_host.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_file_io_host.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_file_system_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 2 11 chunks +29 lines, -26 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 22 chunks +37 lines, -35 lines 0 comments Download
M content/renderer/pepper/pepper_url_loader_host.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_url_loader_host.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_video_capture_host.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_video_capture_host.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.h View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 2 10 chunks +18 lines, -13 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M content/renderer/render_view_pepper_helper.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_pepper_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/audio_helper.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/host_array_buffer_var.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/host_globals.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/host_globals.cc View 1 2 6 chunks +8 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/host_var_tracker_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/message_channel.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/message_channel.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 2 4 chunks +17 lines, -17 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 7 chunks +20 lines, -18 lines 0 comments Download
M webkit/plugins/ppapi/npapi_glue.h View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/npapi_glue.cc View 1 2 8 chunks +15 lines, -13 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 2 9 chunks +19 lines, -19 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 1 2 5 chunks +11 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 7 chunks +10 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/plugin_object.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/plugin_object.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 1 chunk +40 lines, -830 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 1 chunk +0 lines, -2699 lines 0 comments Download
A + webkit/plugins/ppapi/ppapi_plugin_instance_impl.h View 15 chunks +55 lines, -89 lines 0 comments Download
A + webkit/plugins/ppapi/ppapi_plugin_instance_impl.cc View 84 chunks +369 lines, -345 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_unittest.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_broker_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_broker_impl.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_buffer_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 2 12 chunks +13 lines, -12 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_proxy_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_scrollbar_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_tcp_server_socket_private_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_tcp_socket_private_impl.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_var_deprecated_impl.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_widget_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_x509_certificate_private_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/quota_file_io.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/quota_file_io_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_helper.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/resource_helper.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
7 years, 5 months ago (2013-07-24 17:34:51 UTC) #1
scottmg
lgtm https://codereview.chromium.org/19744007/diff/1/chrome/renderer/pepper/ppb_pdf_impl.cc File chrome/renderer/pepper/ppb_pdf_impl.cc (right): https://codereview.chromium.org/19744007/diff/1/chrome/renderer/pepper/ppb_pdf_impl.cc#newcode311 chrome/renderer/pepper/ppb_pdf_impl.cc:311: void HistogramPDFPageCount(PP_Instance instance, int count) { is that ...
7 years, 5 months ago (2013-07-24 18:15:39 UTC) #2
jam
7 years, 5 months ago (2013-07-24 18:49:29 UTC) #3 
https://codereview.chromium.org/19744007/diff/1/chrome/renderer/pepper/ppb_pd...
File chrome/renderer/pepper/ppb_pdf_impl.cc (right):

https://codereview.chromium.org/19744007/diff/1/chrome/renderer/pepper/ppb_pd...
chrome/renderer/pepper/ppb_pdf_impl.cc:311: void
HistogramPDFPageCount(PP_Instance instance, int count) {
On 2013/07/24 18:15:39, scottmg wrote:
> is that going to cause a warning/break somewhere?

nope, this is just code that doesn't follow the chrome conventions

https://codereview.chromium.org/19744007/diff/25001/webkit/plugins/ppapi/audi...
File webkit/plugins/ppapi/audio_helper.h (right):

https://codereview.chromium.org/19744007/diff/25001/webkit/plugins/ppapi/audi...
webkit/plugins/ppapi/audio_helper.h:17: #include
"webkit/plugins/ppapi/ppapi_plugin_instance_impl.h"
On 2013/07/24 18:15:39, scottmg wrote:
> looks unnecessary (?)

Done.

Powered by Google App Engine
This is Rietveld 408576698