Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: webkit/plugins/ppapi/plugin_module.h

Issue 19744007: Create a public API around webkit::ppapi::PluginInstance and use it in chrome. After this, webkit/p… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments and undo checkdeps change Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/plugin_delegate.h ('k') | webkit/plugins/ppapi/plugin_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/plugin_module.h
===================================================================
--- webkit/plugins/ppapi/plugin_module.h (revision 213462)
+++ webkit/plugins/ppapi/plugin_module.h (working copy)
@@ -49,7 +49,7 @@
namespace ppapi {
class PluginDelegate;
-class PluginInstance;
+class PluginInstanceImpl;
// Represents one plugin library loaded into one renderer. This library may
// have multiple instances.
@@ -81,7 +81,7 @@
virtual ~EmbedderState() {}
};
- typedef std::set<PluginInstance*> PluginInstanceSet;
+ typedef std::set<PluginInstanceImpl*> PluginInstanceSet;
// You must call one of the Init functions after the constructor to create a
// module of the type you desire.
@@ -126,7 +126,8 @@
// InitAsProxied must be called before calling InitAsProxiedExternalPlugin.
// Returns a result code indicating whether the proxy started successfully or
// there was an error.
- PP_ExternalPluginResult InitAsProxiedExternalPlugin(PluginInstance* instance);
+ PP_ExternalPluginResult InitAsProxiedExternalPlugin(
+ PluginInstanceImpl* instance);
bool IsProxied() const;
@@ -162,16 +163,16 @@
const base::FilePath& path() const { return path_; }
const ::ppapi::PpapiPermissions& permissions() const { return permissions_; }
- PluginInstance* CreateInstance(PluginDelegate* delegate,
- content::RenderView* render_view,
- WebKit::WebPluginContainer* container,
- const GURL& plugin_url);
+ PluginInstanceImpl* CreateInstance(PluginDelegate* delegate,
+ content::RenderView* render_view,
+ WebKit::WebPluginContainer* container,
+ const GURL& plugin_url);
// Returns "some" plugin instance associated with this module. This is not
// guaranteed to be any one in particular. This is normally used to execute
// callbacks up to the browser layer that are not inherently per-instance,
// but the delegate lives only on the plugin instance so we need one of them.
- PluginInstance* GetSomeInstance() const;
+ PluginInstanceImpl* GetSomeInstance() const;
const PluginInstanceSet& GetAllInstances() const { return instances_; }
@@ -182,8 +183,8 @@
// This module is associated with a set of instances. The PluginInstance
// object declares its association with this module in its destructor and
// releases us in its destructor.
- void InstanceCreated(PluginInstance* instance);
- void InstanceDeleted(PluginInstance* instance);
+ void InstanceCreated(PluginInstanceImpl* instance);
+ void InstanceDeleted(PluginInstanceImpl* instance);
scoped_refptr< ::ppapi::CallbackTracker> GetCallbackTracker();
« no previous file with comments | « webkit/plugins/ppapi/plugin_delegate.h ('k') | webkit/plugins/ppapi/plugin_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698