Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: webkit/plugins/ppapi/resource_helper.cc

Issue 19744007: Create a public API around webkit::ppapi::PluginInstance and use it in chrome. After this, webkit/p… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments and undo checkdeps change Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/resource_helper.h ('k') | webkit/plugins/webkit_plugins.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/resource_helper.cc
===================================================================
--- webkit/plugins/ppapi/resource_helper.cc (revision 213462)
+++ webkit/plugins/ppapi/resource_helper.cc (working copy)
@@ -7,33 +7,32 @@
#include "base/logging.h"
#include "ppapi/shared_impl/resource.h"
#include "webkit/plugins/ppapi/host_globals.h"
-#include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
#include "webkit/plugins/ppapi/plugin_module.h"
-#include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
+#include "webkit/plugins/ppapi/ppapi_plugin_instance_impl.h"
namespace webkit {
namespace ppapi {
// static
-PluginInstance* ResourceHelper::GetPluginInstance(
+PluginInstanceImpl* ResourceHelper::GetPluginInstance(
const ::ppapi::Resource* resource) {
return PPInstanceToPluginInstance(resource->pp_instance());
}
-PluginInstance* ResourceHelper::PPInstanceToPluginInstance(
+PluginInstanceImpl* ResourceHelper::PPInstanceToPluginInstance(
PP_Instance instance) {
return HostGlobals::Get()->GetInstance(instance);
}
PluginModule* ResourceHelper::GetPluginModule(
const ::ppapi::Resource* resource) {
- PluginInstance* instance = GetPluginInstance(resource);
+ PluginInstanceImpl* instance = GetPluginInstance(resource);
return instance ? instance->module() : NULL;
}
PluginDelegate* ResourceHelper::GetPluginDelegate(
const ::ppapi::Resource* resource) {
- PluginInstance* instance = GetPluginInstance(resource);
+ PluginInstanceImpl* instance = GetPluginInstance(resource);
return instance ? instance->delegate() : NULL;
}
« no previous file with comments | « webkit/plugins/ppapi/resource_helper.h ('k') | webkit/plugins/webkit_plugins.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698