Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: webkit/plugins/ppapi/host_globals.h

Issue 19744007: Create a public API around webkit::ppapi::PluginInstance and use it in chrome. After this, webkit/p… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments and undo checkdeps change Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/host_array_buffer_var.cc ('k') | webkit/plugins/ppapi/host_globals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/host_globals.h
===================================================================
--- webkit/plugins/ppapi/host_globals.h (revision 213462)
+++ webkit/plugins/ppapi/host_globals.h (working copy)
@@ -16,7 +16,7 @@
namespace webkit {
namespace ppapi {
-class PluginInstance;
+class PluginInstanceImpl;
class PluginModule;
class HostGlobals : public ::ppapi::PpapiGlobals {
@@ -79,7 +79,7 @@
// Adds a new plugin instance to the list of tracked instances, and returns a
// new instance handle to identify it.
- PP_Instance AddInstance(PluginInstance* instance);
+ PP_Instance AddInstance(PluginInstanceImpl* instance);
// Called when a plugin instance was deleted and should no longer be tracked.
// The given handle should be one generated by AddInstance.
@@ -90,7 +90,7 @@
// Returns a pointer to the plugin instance object associated with the given
// instance handle. The return value will be NULL if the handle is invalid or
// if the instance has crashed.
- WEBKIT_PLUGINS_EXPORT PluginInstance* GetInstance(PP_Instance instance);
+ WEBKIT_PLUGINS_EXPORT PluginInstanceImpl* GetInstance(PP_Instance instance);
private:
// PpapiGlobals overrides.
@@ -102,7 +102,7 @@
HostVarTracker host_var_tracker_;
// Tracks all live instances and their associated object.
- typedef std::map<PP_Instance, PluginInstance*> InstanceMap;
+ typedef std::map<PP_Instance, PluginInstanceImpl*> InstanceMap;
InstanceMap instance_map_;
// Tracks all live modules. The pointers are non-owning, the PluginModule
« no previous file with comments | « webkit/plugins/ppapi/host_array_buffer_var.cc ('k') | webkit/plugins/ppapi/host_globals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698