Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 197283025: Use new is*Element() helper functions more in rendering code (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, mstensho+blink_opera.com, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Use new is*Element() helper functions more in rendering code Use new is*Element() helpers more in rendering code. This makes the code clearer and simpler. R=esprehn, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -116 lines) Patch
M Source/core/rendering/HitTestResult.cpp View 6 chunks +20 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderButton.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderDetailsMarker.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFieldset.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 7 chunks +12 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderMeter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 6 chunks +9 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderProgress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/TextAutosizer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 9 months ago (2014-03-16 21:47:05 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-17 20:05:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/197283025/1
6 years, 9 months ago (2014-03-17 20:05:27 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 20:15:05 UTC) #4
Message was sent while issue was closed.
Change committed as 169385

Powered by Google App Engine
This is Rietveld 408576698