Source/core/rendering/RenderFileUploadControl.cpp - Issue 197283025: Use new is*Element() helper functions more in rendering code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFileUploadControl.cpp

Issue 197283025: Use new is*Element() helper functions more in rendering code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderFileUploadControl.cpp

diff --git a/Source/core/rendering/RenderFileUploadControl.cpp b/Source/core/rendering/RenderFileUploadControl.cpp

index 133f8a83af0e931af9631e82df58e213e8dcf3ef..de9bfba1d8dddbb3d284571ebb896e37adb7a592 100644

--- a/Source/core/rendering/RenderFileUploadControl.cpp

+++ b/Source/core/rendering/RenderFileUploadControl.cpp

@@ -206,7 +206,7 @@ HTMLInputElement* RenderFileUploadControl::uploadButton() const

// FIXME: This should be on HTMLInputElement as an API like innerButtonElement().

HTMLInputElement* input = toHTMLInputElement(node());

Node* buttonNode = input->userAgentShadowRoot()->firstChild();

- return buttonNode && buttonNode->isHTMLElement() && buttonNode->hasTagName(inputTag) ? toHTMLInputElement(buttonNode) : 0;

+ return isHTMLInputElement(buttonNode) ? toHTMLInputElement(buttonNode) : 0;

}

String RenderFileUploadControl::buttonValue()

« no previous file with comments | « Source/core/rendering/RenderFieldset.cpp ('k') | Source/core/rendering/RenderImage.cpp » ('j') | no next file with comments »