Source/core/rendering/RenderTableCol.cpp - Issue 197283025: Use new is*Element() helper functions more in rendering code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableCol.cpp

Issue 197283025: Use new is*Element() helper functions more in rendering code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderTableCol.cpp

diff --git a/Source/core/rendering/RenderTableCol.cpp b/Source/core/rendering/RenderTableCol.cpp

index 26c5935f97f1d3bd065cfbc31b1acc90e6fc6c8a..60d548ea1de3466c9301d26441ff6576cf25bb9f 100644

--- a/Source/core/rendering/RenderTableCol.cpp

+++ b/Source/core/rendering/RenderTableCol.cpp

@@ -60,9 +60,9 @@ void RenderTableCol::updateFromElement()

{

unsigned oldSpan = m_span;

Node* n = node();

- if (n && (n->hasTagName(colTag) || n->hasTagName(colgroupTag))) {

- HTMLTableColElement* tc = toHTMLTableColElement(n);

- m_span = tc->span();

+ if (n && isHTMLTableColElement(*n)) {

+ HTMLTableColElement& tc = toHTMLTableColElement(*n);

+ m_span = tc.span();

} else

m_span = !(style() && style()->display() == TABLE_COLUMN_GROUP);

if (m_span != oldSpan && style() && parent())