Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/core/rendering/RenderDetailsMarker.cpp

Issue 197283025: Use new is*Element() helper functions more in rendering code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderCounter.cpp ('k') | Source/core/rendering/RenderFieldset.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, 2011 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2010, 2011 Nokia Corporation and/or its subsidiary(-ies)
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 * 18 *
19 */ 19 */
20 20
21 #include "config.h" 21 #include "config.h"
22 #include "core/rendering/RenderDetailsMarker.h" 22 #include "core/rendering/RenderDetailsMarker.h"
23 23
24 #include "HTMLNames.h" 24 #include "HTMLNames.h"
25 #include "core/dom/Element.h" 25 #include "core/dom/Element.h"
26 #include "core/html/HTMLElement.h"
26 #include "core/rendering/PaintInfo.h" 27 #include "core/rendering/PaintInfo.h"
27 #include "platform/graphics/GraphicsContext.h" 28 #include "platform/graphics/GraphicsContext.h"
28 29
29 namespace WebCore { 30 namespace WebCore {
30 31
31 using namespace HTMLNames; 32 using namespace HTMLNames;
32 33
33 RenderDetailsMarker::RenderDetailsMarker(Element* element) 34 RenderDetailsMarker::RenderDetailsMarker(Element* element)
34 : RenderBlockFlow(element) 35 : RenderBlockFlow(element)
35 { 36 {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 135
135 boxOrigin.move(borderLeft() + paddingLeft(), borderTop() + paddingTop()); 136 boxOrigin.move(borderLeft() + paddingLeft(), borderTop() + paddingTop());
136 paintInfo.context->fillPath(getPath(boxOrigin)); 137 paintInfo.context->fillPath(getPath(boxOrigin));
137 } 138 }
138 139
139 bool RenderDetailsMarker::isOpen() const 140 bool RenderDetailsMarker::isOpen() const
140 { 141 {
141 for (RenderObject* renderer = parent(); renderer; renderer = renderer->paren t()) { 142 for (RenderObject* renderer = parent(); renderer; renderer = renderer->paren t()) {
142 if (!renderer->node()) 143 if (!renderer->node())
143 continue; 144 continue;
144 if (renderer->node()->hasTagName(detailsTag)) 145 if (isHTMLDetailsElement(*renderer->node()))
145 return !toElement(renderer->node())->getAttribute(openAttr).isNull() ; 146 return !toElement(renderer->node())->getAttribute(openAttr).isNull() ;
146 if (renderer->node()->hasTagName(inputTag)) 147 if (isHTMLInputElement(*renderer->node()))
147 return true; 148 return true;
148 } 149 }
149 150
150 return false; 151 return false;
151 } 152 }
152 153
153 } 154 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderCounter.cpp ('k') | Source/core/rendering/RenderFieldset.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698