Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 19724003: Revert "Transition modules/** to use ExceptionState" (Closed)

Created:
7 years, 5 months ago by Hajime Morrita
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, alecflett, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dgrogan
Visibility:
Public.

Description

Revert "Transition modules/** to use ExceptionState" This reverts commit 7a39480bcf9f305c3f2c77c1ea0a74fa466d91cc. Conflicts: Source/modules/webaudio/AudioBuffer.cpp Source/modules/webaudio/AudioBuffer.h TBR=arv BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+578 lines, -617 lines) Patch
M Source/bindings/v8/custom/V8CryptoCustom.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionCustom.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/AesCbcParams.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/AesKeyGenParams.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/Crypto.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/Crypto.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/crypto/CryptoOperation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.h View 1 chunk +7 lines, -6 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 6 chunks +7 lines, -8 lines 0 comments Download
M Source/modules/indexeddb/IDBFactoryBackendInterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/mediasource/MediaSource.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 6 chunks +11 lines, -13 lines 0 comments Download
M Source/modules/mediasource/MediaSourceBase.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 9 chunks +12 lines, -13 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.h View 3 chunks +7 lines, -8 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 8 chunks +15 lines, -17 lines 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.cpp View 5 chunks +11 lines, -13 lines 0 comments Download
M Source/modules/mediasource/WebKitSourceBuffer.h View 2 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/mediasource/WebKitSourceBuffer.cpp View 7 chunks +10 lines, -12 lines 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.h View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 2 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 4 chunks +18 lines, -17 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 15 chunks +67 lines, -68 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.h View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 9 chunks +15 lines, -16 lines 0 comments Download
M Source/modules/notifications/Notification.h View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 6 chunks +10 lines, -11 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.h View 2 chunks +7 lines, -8 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AnalyserNode.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/modules/webaudio/AnalyserNode.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioBasicInspectorNode.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioBasicInspectorNode.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioBuffer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioBuffer.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 3 chunks +28 lines, -29 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 10 chunks +33 lines, -34 lines 0 comments Download
M Source/modules/webaudio/AudioNode.h View 3 chunks +8 lines, -7 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 10 chunks +17 lines, -18 lines 0 comments Download
M Source/modules/webaudio/BiquadFilterNode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/webaudio/DelayNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/DelayNode.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/modules/webaudio/OscillatorNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/WaveShaperNode.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/webaudio/WaveShaperNode.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBasicTypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLError.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/SQLResultSet.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLResultSet.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackendSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/WebSocket.h View 4 chunks +15 lines, -16 lines 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 12 chunks +43 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
Committed patchset #1 manually as r154455 (presubmit successful).
7 years, 5 months ago (2013-07-18 02:01:16 UTC) #1
arv (Not doing code reviews)
LGTM Wow, the commit bot committed something with merge conflicts?
7 years, 5 months ago (2013-07-18 17:59:39 UTC) #2
arv (Not doing code reviews)
Why was this reverteed? Was there a merge conflict??? On Thu, Jul 18, 2013 at ...
7 years, 5 months ago (2013-07-18 18:50:35 UTC) #3
Hajime Morrita
Sorry for lack of the explanation. This caused bunch of assertion failures on ExceptionState.
7 years, 5 months ago (2013-07-19 00:20:57 UTC) #4
arv (Not doing code reviews)
7 years, 5 months ago (2013-07-19 00:24:54 UTC) #5
That makes more sense. I'll make sure I run this in debug mode before
trying again.

On Thu, Jul 18, 2013 at 8:20 PM,  <morrita@chromium.org> wrote:
> Sorry for lack of the explanation. This caused bunch of assertion failures
> on
> ExceptionState.
>
> https://codereview.chromium.org/19724003/



-- 
erik

Powered by Google App Engine
This is Rietveld 408576698