Pass column as 4th argument to WorkerGlobalScope.onerror handler

Pass column as 4th argument to WorkerGlobalScope.onerror handler

As per the latest WebWorker specification, the WorkerGlobalScope.onerror
event handler should be given the column as fourth argument:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#onerroreventhandler

The behavior is consistent with IE10.

Note that ErrorEvent.column is not exposed yet because no other browser
implements it except IE10 which uses a different name ("colno").

BUG=262126
R=abarth@chromium.org, arv@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154630

[do-not-use, 2013-07-19 15:42:24]

Note that the following test is still not passing:
http://samples.msdn.microsoft.com/ietestcenter/WebWorkers/webworkers_harness....

The reason for that is that the column value v8 returns is 21 but the test
expects 13. I'm not sure where the cause is.

As far as I can tell, the test is correct:
The throw statement is at line 6 col 13 in ErrorEvent.js.

[haraken, 2013-07-19 15:57:31]

arv would be the best reviewer for this.

https://codereview.chromium.org/19693006/diff/1/Source/core/dom/ErrorEvent.idl
File Source/core/dom/ErrorEvent.idl (right):

https://codereview.chromium.org/19693006/diff/1/Source/core/dom/ErrorEvent.id...
Source/core/dom/ErrorEvent.idl:37: //[InitializedByEventConstructor] readonly
attribute unsigned long column;

Please add a FIXME.

[arv (Not doing code reviews), 2013-07-19 16:03:58]

LGTM

[arv (Not doing code reviews), 2013-07-19 16:04:44]

Actually, it seems like our test coverage is a bit thin here. Do you mind adding
a non worker test as well?

[do-not-use, 2013-07-19 16:51:42]

On 2013/07/19 16:04:44, arv wrote:
> Actually, it seems like our test coverage is a bit thin here. Do you mind
adding
> a non worker test as well?

Done.

[do-not-use, 2013-07-19 16:53:10]

I still need OWNER review for the changes under Source/web.

[arv (Not doing code reviews), 2013-07-19 17:04:03]

LGTM

thanks

[do-not-use, 2013-07-19 19:36:07]

abarth@, could you please take a look as well?

[abarth-chromium, 2013-07-20 02:25:30]

lgtm

[commit-bot: I haz the power, 2013-07-20 06:33:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19693006/13001

[commit-bot: I haz the power, 2013-07-20 11:38:23]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-07-20 12:24:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19693006/13001

[commit-bot: I haz the power, 2013-07-20 15:52:46]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[do-not-use, 2013-07-22 06:59:13]

Committed patchset #4 manually as r154630 (presubmit successful).