LayoutTests/fast/events/window-onerror5.html - Issue 19693006: Pass column as 4th argument to WorkerGlobalScope.onerror handler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/window-onerror5.html

Issue 19693006: Pass column as 4th argument to WorkerGlobalScope.onerror handler (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <script>	1 <script>

2 if (window.testRunner)	2 if (window.testRunner)

3 testRunner.dumpAsText();	3 testRunner.dumpAsText();

4	4

5 function log(msg) {	5 function log(msg) {

6 document.getElementById("console").innerHTML += msg + "<br>";	6 document.getElementById("console").innerHTML += msg + "<br>";

7 }	7 }

8	8

9 function test1()	9 function test1()

10 {	10 {

11 window.onerror = function (error, url, line) {	11 window.onerror = function (error, url, line, column) {

12 url = url ? url.match( /[^\/]+\/?$/ )[0] : url;	12 url = url ? url.match( /[^\/]+\/?$/ )[0] : url;

13 log("Error caught successfully: " + error + "\nFile: " + url + "\nLine: " + line)	13 log("Error caught successfully: " + error + "\nFile: " + url + "\nLine: " + line + "\nColumn: " + column)

14 return true;	14 return true;

15 };	15 };

16 eval("a(");	16 eval("a(");

17 }	17 }

18 </script>	18 </script>

19 <body onload="test1();">	19 <body onload="test1();">

20 <p>Test that window.onerror is invoked for syntax error in eval. You should see a log record if window.onerror is working properly for this test.<a href="https: //bugs.webkit.org/show_bug.cgi?id=8519">Bug 8519</a>.</p>	20 <p>Test that window.onerror is invoked for syntax error in eval. You should see a log record if window.onerror is working properly for this test.<a href="https: //bugs.webkit.org/show_bug.cgi?id=8519">Bug 8519</a>.</p>

21 <hr>	21 <hr>

22 <div id='console'></div>	22 <div id='console'></div>

23 </body>	23 </body>

OLD	NEW