Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: Source/core/dom/ErrorEvent.h

Issue 19693006: Pass column as 4th argument to WorkerGlobalScope.onerror handler (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/ErrorEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ErrorEvent.h
diff --git a/Source/core/dom/ErrorEvent.h b/Source/core/dom/ErrorEvent.h
index 0c2a4532eee1176ed548a1fb98be32c307e68496..1e57e25c112a6c213e1811a677d8b9d6250aefd2 100644
--- a/Source/core/dom/ErrorEvent.h
+++ b/Source/core/dom/ErrorEvent.h
@@ -42,6 +42,7 @@ struct ErrorEventInit : public EventInit {
String message;
String filename;
unsigned lineno;
+ unsigned column;
};
class ErrorEvent : public Event {
@@ -50,9 +51,9 @@ public:
{
return adoptRef(new ErrorEvent);
}
- static PassRefPtr<ErrorEvent> create(const String& message, const String& fileName, unsigned lineNumber)
+ static PassRefPtr<ErrorEvent> create(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber)
{
- return adoptRef(new ErrorEvent(message, fileName, lineNumber));
+ return adoptRef(new ErrorEvent(message, fileName, lineNumber, columnNumber));
}
static PassRefPtr<ErrorEvent> create(const AtomicString& type, const ErrorEventInit& initializer)
{
@@ -63,17 +64,19 @@ public:
const String& message() const { return m_message; }
const String& filename() const { return m_fileName; }
unsigned lineno() const { return m_lineNumber; }
+ unsigned column() const { return m_columnNumber; }
virtual const AtomicString& interfaceName() const;
private:
ErrorEvent();
- ErrorEvent(const String& message, const String& fileName, unsigned lineNumber);
+ ErrorEvent(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber);
ErrorEvent(const AtomicString&, const ErrorEventInit&);
String m_message;
String m_fileName;
unsigned m_lineNumber;
+ unsigned m_columnNumber;
};
} // namespace WebCore
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/ErrorEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698