LayoutTests/fast/events/window-onerror8.html - Issue 19693006: Pass column as 4th argument to WorkerGlobalScope.onerror handler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/window-onerror8.html

Issue 19693006: Pass column as 4th argument to WorkerGlobalScope.onerror handler (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3 <p>Test that window.onerror is called on window object. <a href="https://bugs.we bkit.org/show_bug.cgi?id=8519">Bug 8519</a>.</p>	3 <p>Test that window.onerror is called on window object. <a href="https://bugs.we bkit.org/show_bug.cgi?id=8519">Bug 8519</a>.</p>

4 <div id="console"></div>	4 <div id="console"></div>

5 <script>	5 <script>

6 if (window.testRunner)	6 if (window.testRunner)

7 testRunner.dumpAsText();	7 testRunner.dumpAsText();

8	8

9 function log(msg) {	9 function log(msg) {

10 document.getElementById("console").innerHTML += msg + "<br>";	10 document.getElementById("console").innerHTML += msg + "<br>";

11 }	11 }

12	12

13 window.onerror = function(msg, url, line)	13 window.onerror = function(msg, url, line, column)

14 {	14 {

15 url = url ? url.match( /[^\/]+\/?$/ )[0] : url;	15 url = url ? url.match( /[^\/]+\/?$/ )[0] : url;

16 log("Main frame window.onerror: " + msg + " at " + url + ":" + line);	16 log("Main frame window.onerror: " + msg + " at " + url + ", line: " + line + ", column: " + column);

17 if (this === window)	17 if (this === window)

18 log("PASSED: this === window");	18 log("PASSED: this === window");

19 else	19 else

20 log("FAILED: this === window");	20 log("FAILED: this === window");

21 return true;	21 return true;

22 }	22 }

23	23

24 throw 2010;	24 throw 2010;

25	25

26 </script>	26 </script>

27 </body>	27 </body>

28 </html>	28 </html>

OLD	NEW