Add histograms for notices about other forms of browsing history

Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,rkaplow@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.

[msramek, 2016-05-12 10:57:17]

Description was changed from

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

to

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,jyquinn@...

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

[msramek, 2016-05-12 10:57:36]

Description was changed from

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,jyquinn@...

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

to

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,rkaplow@...

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

[msramek, 2016-05-12 10:57:56]

msramek@chromium.org changed reviewers:
+ dbeam@chromium.org, dfalcantara@chromium.org, jyquinn@chromium.org,
rkaplow@chromium.org

[msramek, 2016-05-12 10:59:21]

Merging https://codereview.chromium.org/1948633002 to M51, TBR-ing the original
reviewers.

There was a merge conflict in settings_clear_browsing_data_handler.cc, as the
file in the M51 branch does not contain the functionality we were measuring yet;
there, the file was simply left as-is.

[msramek, 2016-05-12 10:59:29]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-05-12 10:59:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968983002/1

[commit-bot: I haz the power, 2016-05-12 10:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 10:59:43]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[msramek, 2016-05-12 11:00:49]

Description was changed from

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,rkaplow@...

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

to

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,rkaplow@...
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

[msramek, 2016-05-12 11:00:54]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-05-12 11:01:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968983002/1

[commit-bot: I haz the power, 2016-05-12 11:02:39]

Description was changed from

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,rkaplow@...
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

to

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,rkaplow@...
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1948633002
Cr-Commit-Position: refs/heads/master@{#391682}
(cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76)

NOTE! A conflict appeared in
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc,
as in the 2704 branch this file does not contain the functionality which
the histogram was supposed to measure. There, we simply keep the state
of the file on HEAD.
==========

[commit-bot: I haz the power, 2016-05-12 11:02:40]

Committed patchset #1 (id:1)