Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 1968983002: Add histograms for notices about other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
index 8e529c1e7467c22a1625ddcf1938a02ba42a6610..ae3433804f91ce1f9adb7faafc547ffce72f4f17 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
@@ -350,6 +350,9 @@ void ClearBrowserDataHandler::OnBrowsingDataRemoverDone() {
notice_shown_times + 1);
}
+ UMA_HISTOGRAM_BOOLEAN(
+ "History.ClearBrowsingData.ShownHistoryNoticeAfterClearing", show_notice);
+
web_ui()->CallJavascriptFunction(
"ClearBrowserDataOverlay.doneClearing",
base::FundamentalValue(show_notice));
@@ -413,6 +416,10 @@ void ClearBrowserDataHandler::RefreshHistoryNotice() {
void ClearBrowserDataHandler::UpdateHistoryNotice(bool show) {
should_show_history_notice_ = show;
OnStateChanged();
+
+ UMA_HISTOGRAM_BOOLEAN(
+ "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated",
+ should_show_history_notice_);
}
void ClearBrowserDataHandler::UpdateHistoryDeletionDialog(bool show) {
« no previous file with comments | « chrome/browser/ui/webui/browsing_history_handler.cc ('k') | ios/chrome/browser/ui/webui/history/browsing_history_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698