Add histograms for notices about other forms of browsing history

Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
Committed: https://crrev.com/1f22966d3e45226f3048405f9f5d7d6898285d76
Cr-Commit-Position: refs/heads/master@{#391682}

[msramek, 2016-05-03 19:05:45]

msramek@chromium.org changed reviewers:
+ dbeam@chromium.org, dfalcantara@chromium.org, jyquinn@google.com,
rkaplow@chromium.org

[msramek, 2016-05-03 19:05:46]

Hi folks,

Can you please have a look?

dbeam@: Desktop
jyquinn@: iOS
dfalcantara@: Android
rkaplow@: histograms.xml

Thanks,
Martin

[Jackie Quinn, 2016-05-03 23:31:16]

On 2016/05/03 19:05:46, msramek wrote:
> Hi folks,
> 
> Can you please have a look?
> 
> dbeam@: Desktop
> jyquinn@: iOS
> dfalcantara@: Android
> rkaplow@: histograms.xml
> 
> Thanks,
> Martin

ios lgtm

[Dan Beam, 2016-05-03 23:39:15]

lgtm

[gone, 2016-05-04 01:31:09]

android lgtm

[msramek, 2016-05-04 21:10:19]

Thanks, everyone!

rkaplow@: I'll be OOO for a few days, so in case this LGTY, please also check
the CQ :) Thanks!

[rkaplow, 2016-05-04 21:11:54]

lgtm

[msramek, 2016-05-04 21:49:10]

Thanks!

I took one last pass before landing, and noticed that I accidentally used the
same histogram twice in the CBD dialog on Android instead of using the two
different ones.

Fixed that in the last patchset, triple-checked, and landing now. :)

[msramek, 2016-05-04 21:49:24]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-05-04 21:49:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, dbeam@chromium.org, jyquinn@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1948633002/#ps40001
(title: "Android Fix")

[commit-bot: I haz the power, 2016-05-04 21:49:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948633002/40001

[commit-bot: I haz the power, 2016-05-04 23:18:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 23:19:59]

Description was changed from

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842
==========

to

==========
Add histograms for notices about other forms of browsing history

Notices about the existence of other forms of browsing history on
history.google.com are shown to users in the header of the History page,
footer of the Clear Browsing Data dialog, and an additional dialog on top
of the CBD dialog after history deletion; but only to those users for
whom they are relevant.

This CL adds histograms that are recorded whenever one of the described
UI elements is shown and records whether we also showed the notice or not
(thus computing the amount and ratio of users for whom we decided to show
the notice).

Implemented:
- History page (shared between Desktop and Android)
- History page (iOS)
- CBD dialog (Desktop WebUI)
- CBD dialog (Desktop MD, only the footer)
- CBD dialog (Android)

Missing (will be added in followup CLs):
- CBD dialog (iOS) - not part of Chromium repo
- CBD dialog (Desktop MD, history deletion dialog) - does not exist yet

BUG=608842

Committed: https://crrev.com/1f22966d3e45226f3048405f9f5d7d6898285d76
Cr-Commit-Position: refs/heads/master@{#391682}
==========

[commit-bot: I haz the power, 2016-05-04 23:20:00]

Patchset 3 (id:??) landed as
https://crrev.com/1f22966d3e45226f3048405f9f5d7d6898285d76
Cr-Commit-Position: refs/heads/master@{#391682}