Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4628)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

Issue 1968983002: Add histograms for notices about other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/preferences/pref_service_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
index 85b635d8a05751d684666212e9e1864308713c2f..7538d1c9c8598194bd2397be002fe1e347616238 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
@@ -12,6 +12,7 @@ import android.preference.PreferenceFragment;
import android.widget.ListView;
import org.chromium.base.VisibleForTesting;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.BrowsingDataType;
import org.chromium.chrome.browser.TimePeriod;
@@ -128,6 +129,10 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment
/** The tag used for logging. */
public static final String TAG = "ClearBrowsingDataPreferences";
+ /** The histogram for the dialog about other forms of browsing history. */
+ private static final String DIALOG_HISTOGRAM =
+ "History.ClearBrowsingData.ShownHistoryNoticeAfterClearing";
+
/** The web history URL. */
private static final String WEB_HISTORY_URL =
"https://history.google.com/history/?utm_source=chrome_cbd";
@@ -296,9 +301,11 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment
mDialogAboutOtherFormsOfBrowsingHistory =
OtherFormsOfHistoryDialogFragment.show(getActivity());
dismissProgressDialog();
+ RecordHistogram.recordBooleanHistogram(DIALOG_HISTOGRAM, true);
} else {
dismissProgressDialog();
getActivity().finish();
+ RecordHistogram.recordBooleanHistogram(DIALOG_HISTOGRAM, false);
}
}
« no previous file with comments | « no previous file | chrome/browser/android/preferences/pref_service_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698