Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 1968443002: Kill the autofill password manager in case 'store()' was called. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, jam, darin-cc_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Kill the autofill password manager in case 'store()' was called. The previous CL (https://codereview.chromium.org/1929953002) kinda did the same thing but only for saving a credential. At the same time it shouldn't be any different from silently updating the existing one. Once the site calls 'store()' it demonstrates that it posses a valid credential. Therefore, the autofill password manager shouldn't intervene. BUG=610328 Review-Url: https://codereview.chromium.org/1962713002 Cr-Commit-Position: refs/heads/master@{#392337} (cherry picked from commit f0a4e30ea6dd8a17ff2fda49239037452e4b44b1) R=vabr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/249dd91407d778daed55e2a3a4abedb9e69ff527

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
vasilii
Hi Vaclav, please review.
4 years, 7 months ago (2016-05-10 10:11:03 UTC) #2
vabr (Chromium)
lgtm
4 years, 7 months ago (2016-05-10 10:40:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968443002/1
4 years, 7 months ago (2016-05-10 10:46:14 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-10 10:46:17 UTC) #7
vasilii
4 years, 7 months ago (2016-05-10 10:52:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
249dd91407d778daed55e2a3a4abedb9e69ff527 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698