Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3427)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1968443002: Kill the autofill password manager in case 'store()' was called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index f47795c27287cc2b2672bb7392cdb0afe5a44805..fd4d1eabbaa21f90a90f816cae77a4ae95a82b41 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -223,10 +223,6 @@ bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
return false;
}
- // Prevent the autofill password manager from prompting the second time.
- if (type == password_manager::CredentialSourceType::CREDENTIAL_SOURCE_API)
- password_manager_.DropFormManagers();
-
if (IsTheHotNewBubbleUIEnabled()) {
#if !BUILDFLAG(ANDROID_JAVA_UI)
PasswordsClientUIDelegate* manage_passwords_ui_controller =
@@ -343,6 +339,12 @@ void ChromePasswordManagerClient::NotifySuccessfulLoginWithExistingPassword(
possible_auto_sign_in_.reset();
}
+void ChromePasswordManagerClient::NotifyStorePasswordCalled() {
+ // If a site stores a credential the autofill password manager shouldn't kick
+ // in.
+ password_manager_.DropFormManagers();
+}
+
void ChromePasswordManagerClient::AutomaticPasswordSave(
std::unique_ptr<password_manager::PasswordFormManager> saved_form) {
#if BUILDFLAG(ANDROID_JAVA_UI)

Powered by Google App Engine
This is Rietveld 408576698