Suppress the autofill password manager after a credential was saved via the API.

Suppress the autofill password manager after a credential was saved via the API.

Without this the user may see two save prompts one after another.

BUG=607501
Committed: https://crrev.com/86f6265c50793ff42c9853640610c20ba5eadbf6
Cr-Commit-Position: refs/heads/master@{#390384}

[vasilii, 2016-04-28 13:49:04]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-04-28 13:49:05]

Hi Vaclav,

please review.

[vabr (Chromium), 2016-04-28 14:11:04]

This LGTM, thanks!

I double-checked that the call to PromptUserToSaveOrUpdatePassword with
CREDENTIAL_SOURCE_API happens as soon as it gets the data from the password
store, which it requests as soon as store() is called.

PromptUserToSaveOrUpdatePassword with CREDENTIAL_SOURCE_PASSWORD_MANAGER is
called once the landing page completes loading, so that's very likely after the
call from the CM API.

Cheers,
Vaclav

https://codereview.chromium.org/1929953002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/password_manager_test_base.cc (right):

https://codereview.chromium.org/1929953002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/password_manager_test_base.cc:153:
static_cast<content::WebContentsObserver*>(
nit: Could you please add a code comment explaining why we need to tell the
model delegate that the main frame navigated?

[vasilii, 2016-04-28 14:22:29]

https://codereview.chromium.org/1929953002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/password_manager_test_base.cc (right):

https://codereview.chromium.org/1929953002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/password_manager_test_base.cc:153:
static_cast<content::WebContentsObserver*>(
On 2016/04/28 14:11:04, vabr (Chromium) wrote:
> nit: Could you please add a code comment explaining why we need to tell the
> model delegate that the main frame navigated?

Done.

[vasilii, 2016-04-28 14:22:34]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-04-28 14:22:35]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1929953002/#ps20001
(title: "add a comment")

[commit-bot: I haz the power, 2016-04-28 14:22:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929953002/20001

[commit-bot: I haz the power, 2016-04-28 15:13:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:18:39]

Patchset 2 (id:??) landed as
https://crrev.com/86f6265c50793ff42c9853640610c20ba5eadbf6
Cr-Commit-Position: refs/heads/master@{#390384}

[commit-bot: I haz the power, 2016-04-30 17:55:50]

Description was changed from

==========
Suppress the autofill password manager after a credential was saved via the API.

Without this the user may see two save prompts one after another.

BUG=607501
==========

to

==========
Suppress the autofill password manager after a credential was saved via the API.

Without this the user may see two save prompts one after another.

BUG=607501

Committed: https://crrev.com/86f6265c50793ff42c9853640610c20ba5eadbf6
Cr-Commit-Position: refs/heads/master@{#390384}
==========