Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1962713002: Kill the autofill password manager in case 'store()' was called. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, jam, darin-cc_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Kill the autofill password manager in case 'store()' was called. The previous CL (https://codereview.chromium.org/1929953002) kinda did the same thing but only for saving a credential. At the same time it shouldn't be any different from silently updating the existing one. Once the site calls 'store()' it demonstrates that it posses a valid credential. Therefore, the autofill password manager shouldn't intervene. BUG=610328 Committed: https://crrev.com/f0a4e30ea6dd8a17ff2fda49239037452e4b44b1 Cr-Commit-Position: refs/heads/master@{#392337}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
vasilii
Hi Vaclav, please review.
4 years, 7 months ago (2016-05-09 15:39:24 UTC) #2
vabr (Chromium)
LGTM, thanks! Vaclav
4 years, 7 months ago (2016-05-09 15:49:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962713002/1
4 years, 7 months ago (2016-05-09 15:53:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 16:49:08 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 16:51:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0a4e30ea6dd8a17ff2fda49239037452e4b44b1
Cr-Commit-Position: refs/heads/master@{#392337}

Powered by Google App Engine
This is Rietveld 408576698