Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1967513002: Revert of Replace GrStrokeInfo with GrStyle. (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@resscale
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Replace GrStrokeInfo with GrStyle. (patchset #4 id:160001 of https://codereview.chromium.org/1957363002/ ) Reason for revert: Breaking some bots Original issue's description: > Replace GrStrokeInfo with GrStyle. > > A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002 > > Committed: https://skia.googlesource.com/skia/+/33595bdf4b64a745f6340338d307e806e96c587f TBR=egdaniel@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/85d9667f59d4138438427bb2cdf67992d100e1a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+934 lines, -696 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrDrawContext.h View 7 chunks +19 lines, -12 lines 0 comments Download
M include/gpu/GrTestUtils.h View 3 chunks +4 lines, -31 lines 0 comments Download
M src/gpu/GrBlurUtils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 9 chunks +113 lines, -73 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 10 chunks +10 lines, -8 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 21 chunks +79 lines, -78 lines 0 comments Download
M src/gpu/GrPath.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrPath.cpp View 5 chunks +37 lines, -63 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 10 chunks +17 lines, -13 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathRendering.h View 3 chunks +12 lines, -14 lines 0 comments Download
M src/gpu/GrPathRendering.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 4 chunks +16 lines, -6 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
A src/gpu/GrStrokeInfo.h View 1 chunk +191 lines, -0 lines 0 comments Download
A src/gpu/GrStrokeInfo.cpp View 1 chunk +93 lines, -0 lines 0 comments Download
M src/gpu/GrStyle.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/gpu/GrTestUtils.cpp View 2 chunks +22 lines, -49 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 9 chunks +16 lines, -12 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 3 chunks +12 lines, -21 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 4 chunks +6 lines, -10 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 3 chunks +12 lines, -16 lines 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 6 chunks +22 lines, -21 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 5 chunks +9 lines, -11 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 8 chunks +47 lines, -53 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 6 chunks +24 lines, -19 lines 0 comments Download
M src/gpu/gl/GrGLPath.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 6 chunks +24 lines, -20 lines 0 comments Download
M src/gpu/gl/GrGLPathRange.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPathRange.cpp View 5 chunks +30 lines, -23 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 7 chunks +27 lines, -52 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Replace GrStrokeInfo with GrStyle.
4 years, 7 months ago (2016-05-10 13:18:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967513002/1
4 years, 7 months ago (2016-05-10 13:19:06 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 13:19:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/85d9667f59d4138438427bb2cdf67992d100e1a0

Powered by Google App Engine
This is Rietveld 408576698