Replace Element::isMediaElement() with isHTMLMediaElement

Replace Element::isMediaElement() with isHTMLMediaElement

This make HTMLMediaElement type casting more in line with the generated
code for most other HTML elements. Not incidentally, this simplifies the
code in several places.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169293

[philipj_slow, 2014-03-13 18:31:55]

Chris, this was inspired by your cleanup, so PTAL. The only silly bit is that
one must include HTMLMediaElement.h in order to use isHTMLMediaElement, while
isHTMLAudioElement and isHTMLVideoElement are generated and come with
HTMLElement.h. Not a huge deal, and putting the is/to helpers in HTMLElement.h
or even the template seems sillier still.

[Inactive, 2014-03-13 18:46:23]

Lgtm with comments. Thanks for helping with the cleanup!

https://codereview.chromium.org/196723014/diff/1/Source/core/dom/FullscreenEl...
File Source/core/dom/FullscreenElementStack.cpp (right):

https://codereview.chromium.org/196723014/diff/1/Source/core/dom/FullscreenEl...
Source/core/dom/FullscreenElementStack.cpp:193: if
(!UserGestureIndicator::processingUserGesture() && (!isHTMLMediaElement(element)
|| document()->settings()->mediaFullscreenRequiresUserGesture()))
Ditto

https://codereview.chromium.org/196723014/diff/1/Source/core/events/EventPath...
File Source/core/events/EventPath.cpp (right):

https://codereview.chromium.org/196723014/diff/1/Source/core/events/EventPath...
Source/core/events/EventPath.cpp:90: if (isHTMLMediaElement(element) &&
shadowRoot && shadowRoot->host() == element)
*element ? To avoid the null check.

[philipj_slow, 2014-03-13 18:52:54]

Fixed, thanks for catching those!

[philipj_slow, 2014-03-13 18:57:43]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-13 18:57:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/196723014/20001

[Inactive, 2014-03-13 18:59:34]

On 2014/03/13 18:57:45, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/philipj%40opera.com/196723014/20001

You'll need a review for Source/web, I don't own this folder. adamk can probably
take a look.

[Inactive, 2014-03-13 18:59:58]

+adamk

[philipj_slow, 2014-03-13 19:00:53]

Oops, thanks Chris!

[commit-bot: I haz the power, 2014-03-13 19:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 19:16:55]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[philipj_slow, 2014-03-15 00:08:45]

Ping adamk

[adamk, 2014-03-15 00:23:26]

lgtm

[adamk, 2014-03-15 00:23:30]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2014-03-15 00:23:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/196723014/20001

[commit-bot: I haz the power, 2014-03-15 00:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-15 00:23:48]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[philipj_slow, 2014-03-15 00:37:01]

On 2014/03/15 00:23:48, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on blink_presubmit

Looks like I need a more powerful LGTM, calling abarth.

[Inactive, 2014-03-15 00:49:39]

lgtm

It is the bot's problem, adamk is an OWNER for Source/web.

[commit-bot: I haz the power, 2014-03-15 00:49:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/196723014/20001

[commit-bot: I haz the power, 2014-03-15 01:13:17]

Change committed as 169293

[philipj_slow, 2014-03-15 02:37:06]

On 2014/03/15 00:49:39, Chris Dumez wrote:
> lgtm
> 
> It is the bot's problem, adamk is an OWNER for Source/web.

Hmm, weird. Is there a known bug here, or should I report one?

[Inactive, 2014-03-15 02:40:40]

On 2014/03/15 02:37:06, philipj wrote:
> On 2014/03/15 00:49:39, Chris Dumez wrote:
> > lgtm
> > 
> > It is the bot's problem, adamk is an OWNER for Source/web.
> 
> Hmm, weird. Is there a known bug here, or should I report one?

I believe esprehn just sent an email to the mailing list about the same issue.
The bots are getting worse :/