Source/core/html/shadow/MediaControlElementTypes.cpp - Issue 196723014: Replace Element::isMediaElement() with isHTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.cpp

Issue 196723014: Replace Element::isMediaElement() with isHTMLMediaElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: less null checks Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControlElementTypes.cpp

diff --git a/Source/core/html/shadow/MediaControlElementTypes.cpp b/Source/core/html/shadow/MediaControlElementTypes.cpp

index 23f88124472c59739be3dcc46c8b79681c53389d..43d021ec0e5df41754469a1f96c8021f0f67156d 100644

--- a/Source/core/html/shadow/MediaControlElementTypes.cpp

+++ b/Source/core/html/shadow/MediaControlElementTypes.cpp

@@ -52,7 +52,7 @@ HTMLMediaElement* toParentMediaElement(Node* node)

Node* mediaNode = node->shadowHost();

if (!mediaNode)

mediaNode = node;

- if (!mediaNode || !mediaNode->isElementNode() || !toElement(mediaNode)->isMediaElement())

+ if (!isHTMLMediaElement(mediaNode))

return 0;

return toHTMLMediaElement(mediaNode);

« no previous file with comments | « Source/core/html/HTMLTrackElement.cpp ('k') | Source/web/FullscreenController.cpp » ('j') | no next file with comments »