Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: Source/web/FullscreenController.cpp

Issue 196723014: Replace Element::isMediaElement() with isHTMLMediaElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: less null checks Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/MediaControlElementTypes.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FullscreenController.cpp
diff --git a/Source/web/FullscreenController.cpp b/Source/web/FullscreenController.cpp
index 41147ed3fa4dd61ad052d8f6d47fa0017cb21a35..46314cec88c3c525788b2744f65b5e065027667d 100644
--- a/Source/web/FullscreenController.cpp
+++ b/Source/web/FullscreenController.cpp
@@ -88,7 +88,7 @@ void FullscreenController::didEnterFullScreen()
if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()) {
Element* element = FullscreenElementStack::currentFullScreenElementFrom(*doc);
ASSERT(element);
- if (element->isMediaElement() && m_webViewImpl->layerTreeView())
+ if (isHTMLMediaElement(*element) && m_webViewImpl->layerTreeView())
m_webViewImpl->layerTreeView()->setHasTransparentBackground(true);
}
}
@@ -157,7 +157,7 @@ void FullscreenController::enterFullScreenForElement(WebCore::Element* element)
}
if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()
- && element && element->isMediaElement()
+ && isHTMLMediaElement(element)
// FIXME: There is no embedder-side handling in layout test mode.
&& !isRunningLayoutTest()) {
HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
@@ -181,7 +181,7 @@ void FullscreenController::exitFullScreenForElement(WebCore::Element* element)
if (m_isCancelingFullScreen)
return;
if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()
- && element && element->isMediaElement()
+ && isHTMLMediaElement(element)
// FIXME: There is no embedder-side handling in layout test mode.
&& !isRunningLayoutTest()) {
HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
« no previous file with comments | « Source/core/html/shadow/MediaControlElementTypes.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698