Source/core/html/HTMLTrackElement.cpp - Issue 196723014: Replace Element::isMediaElement() with isHTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTrackElement.cpp

Issue 196723014: Replace Element::isMediaElement() with isHTMLMediaElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: less null checks Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTrackElement.cpp

diff --git a/Source/core/html/HTMLTrackElement.cpp b/Source/core/html/HTMLTrackElement.cpp

index fddfcb3350cc79ab14a7ba52421b935e99c87e34..280020b9c9492064b690dfce5aed6e874b2551cb 100644

--- a/Source/core/html/HTMLTrackElement.cpp

+++ b/Source/core/html/HTMLTrackElement.cpp

@@ -267,8 +267,8 @@ const AtomicString& HTMLTrackElement::mediaElementCrossOriginAttribute() const

HTMLMediaElement* HTMLTrackElement::mediaElement() const

{

Element* parent = parentElement();

- if (parent && parent->isMediaElement())

- return toHTMLMediaElement(parentNode());

+ if (isHTMLMediaElement(parent))

+ return toHTMLMediaElement(parent);

return 0;

}