Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 1966943004: Fix smooth progress behavior on JellyBean (Closed)

Created:
4 years, 7 months ago by mdjones
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix smooth progress behavior on JellyBean The animators in JellyBean send a delta time fom the last time an animation played instead of 0 for the first frame after an animation starts. A combination of this and a misplaced "max" function completely derailed the smooth progress bar animation. This change also addresses a crash that only occures on JellyBean that involves early cancellation of a running animation. After the animation is canceled, the animator tries to run doAnimationFrame with an empty list of updates. The animation is now allowed to run itself out. (This should have no visible affect on the animation since it becomes transparent near completion). BUG=611125, 610522 Committed: https://crrev.com/2f8f44e6740bda7e9015e252db16cc869721e3a8 Cr-Commit-Position: refs/heads/master@{#393113}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
mdjones
PTAL
4 years, 7 months ago (2016-05-11 22:29:08 UTC) #2
gone
lgtm
4 years, 7 months ago (2016-05-11 22:34:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966943004/1
4 years, 7 months ago (2016-05-11 22:44:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 00:14:28 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 00:18:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f8f44e6740bda7e9015e252db16cc869721e3a8
Cr-Commit-Position: refs/heads/master@{#393113}

Powered by Google App Engine
This is Rietveld 408576698