Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1808653006: Add tests for the OverlayPanelEventFilter (Closed)

Created:
4 years, 9 months ago by mdjones
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@overlaypaneleventfilter
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for the OverlayPanelEventFilter BUG=584340 Committed: https://crrev.com/e63177a3d418d078a8777d83f817c11e30831d7b Cr-Commit-Position: refs/heads/master@{#393996}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -0 lines) Patch
M chrome/android/java_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelEventFilterTest.java View 1 2 1 chunk +492 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
mdjones
These are the tests that were previously in https://codereview.chromium.org/1739203003/ The problem is that since that ...
4 years, 9 months ago (2016-03-16 20:31:33 UTC) #2
Theresa
lgtm
4 years, 9 months ago (2016-03-16 20:42:17 UTC) #3
pedro (no code reviews)
lgtm
4 years, 9 months ago (2016-03-16 21:14:54 UTC) #4
David Trainor- moved to gerrit
lgtm
4 years, 8 months ago (2016-04-15 15:51:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808653006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808653006/20001
4 years, 7 months ago (2016-05-16 22:34:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808653006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808653006/40001
4 years, 7 months ago (2016-05-16 23:25:46 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 00:45:19 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 00:46:41 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e63177a3d418d078a8777d83f817c11e30831d7b
Cr-Commit-Position: refs/heads/master@{#393996}

Powered by Google App Engine
This is Rietveld 408576698