Force standard progress bar colors if native page

Force standard progress bar colors if native page

Prior to this change, native pages that did not use the default color
caused the progress bar color to be recomputed. This would cause the
progress bar to be an incorrect color when navigating a non-native
page and in the case of pages with no theme, they would never get
updated.

This change adds a parameter to the function responsible for computing
theme color to force the default progress bar color. In practice this
parameter is true if the page is native.

BUG=621847
Committed: https://crrev.com/0f222e201534b983fa45e4218a9e48d051fe140b
Cr-Commit-Position: refs/heads/master@{#402196}

[mdjones, 2016-06-22 22:09:54]

Here is the other option for the theme color fix we discussed.

[Ted C, 2016-06-23 00:00:11]

tedchoc@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-06-23 00:00:12]

https://codereview.chromium.org/2088933002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/2088933002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:2006:
getProgressBar().setThemeColor(currentPrimaryColor, isNativePage,
isIncognito());
instead of adding a new param, could we just only call this if !isNativePage?

then it would be isolated to just this file

[mdjones, 2016-06-23 19:04:27]

https://codereview.chromium.org/2088933002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/2088933002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:2006:
getProgressBar().setThemeColor(currentPrimaryColor, isNativePage,
isIncognito());
On 2016/06/23 00:00:12, Ted C wrote:
> instead of adding a new param, could we just only call this if !isNativePage?
> 
> then it would be isolated to just this file

Isolated to a single file but used a slightly different approach because of the
tab switcher changing the colors.

[Ted C, 2016-06-24 16:19:06]

https://codereview.chromium.org/2088933002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/2088933002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:1995:
themeColorForProgressBar = getToolbarColorForVisualState(VisualState.NORMAL);
What happens if you're on the incognito ntp?

[mdjones, 2016-06-24 17:05:28]

https://codereview.chromium.org/2088933002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/2088933002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:1995:
themeColorForProgressBar = getToolbarColorForVisualState(VisualState.NORMAL);
On 2016/06/24 16:19:06, Ted C wrote:
> What happens if you're on the incognito ntp?

The incognito flag is still passed into the function that computes theme color,
so it should still work.

[Ted C, 2016-06-24 17:35:43]

lgtm

https://codereview.chromium.org/2088933002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/2088933002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:1995:
themeColorForProgressBar = getToolbarColorForVisualState(VisualState.NORMAL);
On 2016/06/24 17:05:28, mdjones wrote:
> On 2016/06/24 16:19:06, Ted C wrote:
> > What happens if you're on the incognito ntp?
> 
> The incognito flag is still passed into the function that computes theme
color,
> so it should still work.

Acknowledged.

[mdjones, 2016-06-27 15:40:06]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-06-27 15:40:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:26:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-27 16:27:44]

Description was changed from

==========
Force standard progress bar colors if native page

Prior to this change, native pages that did not use the default color
caused the progress bar color to be recomputed. This would cause the
progress bar to be an incorrect color when navigating a non-native
page and in the case of pages with no theme, they would never get
updated.

This change adds a parameter to the function responsible for computing
theme color to force the default progress bar color. In practice this
parameter is true if the page is native.

BUG=621847
==========

to

==========
Force standard progress bar colors if native page

Prior to this change, native pages that did not use the default color
caused the progress bar color to be recomputed. This would cause the
progress bar to be an incorrect color when navigating a non-native
page and in the case of pages with no theme, they would never get
updated.

This change adds a parameter to the function responsible for computing
theme color to force the default progress bar color. In practice this
parameter is true if the page is native.

BUG=621847

Committed: https://crrev.com/0f222e201534b983fa45e4218a9e48d051fe140b
Cr-Commit-Position: refs/heads/master@{#402196}
==========

[commit-bot: I haz the power, 2016-06-27 16:27:45]

Patchset 3 (id:??) landed as
https://crrev.com/0f222e201534b983fa45e4218a9e48d051fe140b
Cr-Commit-Position: refs/heads/master@{#402196}