Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2158853004: Do not include toolbar shadow for UIResourceLayer snapshot (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, ntp-dev+reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not include toolbar shadow for UIResourceLayer snapshot This change hides the android-drawn toolbar shadow when taking a snapshot for the compositor. This allows transitioning between tabs that may or may not have the shadow (i.e. the NTP) to be more smooth. BUG=614690

Patch Set 1 #

Patch Set 2 : pull out interface change #

Patch Set 3 : nits #

Patch Set 4 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -37 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java View 1 2 3 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java View 3 chunks +21 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java View 5 chunks +23 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/android/compositor/layer/toolbar_layer.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/toolbar_layer.cc View 1 2 4 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698