Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1965273004: Nanobench running on Vulkan (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@gltotest
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Nanobench running on Vulkan This lets nanobench run but the timings are inaccurate because of missing implementations of synchronization functions in VkTestContext. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1965273004 Committed: https://skia.googlesource.com/skia/+/c8699321b924c1f284df93cb29b86000c1d73c0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -22 lines) Patch
M bench/nanobench.cpp View 4 chunks +24 lines, -21 lines 0 comments Download
M tools/gpu/TestContext.h View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/gpu/TestContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gpu/gl/GLTestContext.h View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gpu/gl/GLTestContext.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/gpu/vk/VkTestContext.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
bsalomon
4 years, 7 months ago (2016-05-11 17:47:59 UTC) #4
egdaniel
lgtm
4 years, 7 months ago (2016-05-11 17:59:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965273004/1
4 years, 7 months ago (2016-05-11 18:24:35 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 18:55:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c8699321b924c1f284df93cb29b86000c1d73c0a

Powered by Google App Engine
This is Rietveld 408576698