Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196523007: Revert of id of iframe incorrectly sets window name (Closed)

Created:
6 years, 9 months ago by eseidel
Modified:
6 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Revert of id of iframe incorrectly sets window name (https://codereview.chromium.org/187103002/) Reason for revert: This may have broken browser_tests: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2034/steps/browser_tests/logs/TabDestroyed Original issue's description: > id of iframe incorrectly sets window name > > As per the specification, the iframe's name should be an empty string if unset: > http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name > > Instead, Chromium was using the iframe's id as window name if the name was > unset. This change makes us behave like Firefox 27 and IE 11, verified using: > http://jsfiddle.net/xf5H7/9/ > > This CL sets the name attribute iframe in a lot of layout tests so that > testRunner.dumpChildFramesAsText() keeps printing the same result. > > R=arv@chromium.org, tkent@chromium.org > BUG=347169 > TEST=fast/frames/iframe-no-name.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168553 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168801 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169304 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169683 TBR=abarth@chromium.org,arv@chromium.org,tkent@chromium.org,ch.dumez@samsung.com NOTREECHECKS=true NOTRY=true BUG=347169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -185 lines) Patch
M LayoutTests/fast/autoresize/autoresize-with-iframe.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-generated-content/positioned-div-with-floating-after-content-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/timeout-callback-scope.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-access-after-navigation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-collection-length-no-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-special-properties-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-context.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/xss-DENIED-javascript-variations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/onbeforeunload-focused-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/open-window-from-another-frame.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/popup-blocked-to-post-blank.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/popup-blocking-click-in-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/popup-when-select-change.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/form-submission-cancelable.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/detach-frame-during-focus.html View 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/fast/frames/frame-inherit-noresize-from-frameset.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/frame-programmatic-noresize.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-location-badstring.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/frames/iframe-no-name.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/frames/iframe-no-name-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/frames/sandboxed-iframe-plugins.html View 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/frames/unload-reparent-sibling-frame.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/history/form-submit-in-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/history/form-submit-in-frame-via-onclick.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/history/same-document-iframes-changing-fragment.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/history/same-document-iframes-changing-pushstate.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/history/saves-state-after-frame-nav.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/images/exif-orientation-image-document.html View 2 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/overflow/scrollRevealButton.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/parser/xml-colon-entity.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/xml-declaration-missing-ending-mark.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/full-screen-frameset.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/loading/redirect-methods.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/loading/text-content-type-with-binary-extension.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/form-target-iframe-location-change.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/location-replace-crossdomain.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/image-load-in-subframe-unload-handler.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/location-change-repeated-from-blank.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/no-referrer-subframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/resources/forward-and-cancel-frames.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-child-explicit-domain.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-document-direct.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-parent-explicit-domain.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-port.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-port-explicit-domain.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-protocol.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-protocol-explicit-domain.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/host-compare-case-insensitive.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-uncaught.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/protocol-compare-case-insensitive.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/referrer-policy-redirect-link.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/srcdoc-inherits-referrer-for-forms.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-base-href.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-iframe-javascript-url.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-iframe-no-inherit.php View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-javascript-link.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-link-onclick.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-object-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-script-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-script-tag-with-source.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-3.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-4.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-5.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-6.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-7.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-8.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-9.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/report-script-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/report-script-tag-replace-state.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/resources/utilities.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/xss-protection-parsing-02.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/xss-protection-parsing-03.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/xss-protection-parsing-04.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unload-sync.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/get-url-with-iframe-target.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/plugin-remove-subframe.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/tests/data/iframe_redirect.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
Created Revert of id of iframe incorrectly sets window name
6 years, 9 months ago (2014-03-21 07:19:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/196523007/1
6 years, 9 months ago (2014-03-21 07:19:41 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 07:20:16 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/http/tests/navigation/no-referrer-subframe.html: While running svn propset svn:eol-style LF LayoutTests/http/tests/navigation/no-referrer-subframe.html --config-dir /b/commit-queue/subversion_config ...
6 years, 9 months ago (2014-03-21 07:20:16 UTC) #4
vsevik
6 years, 9 months ago (2014-03-21 07:51:37 UTC) #5 
I will rebaseline it manually in another issue (could not upload a patch here).

Powered by Google App Engine
This is Rietveld 408576698