LayoutTests/fullscreen/full-screen-frameset.html - Issue 196523007: Revert of id of iframe incorrectly sets window name

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-frameset.html

Issue 196523007: Revert of id of iframe incorrectly sets window name (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <script src="full-screen-test.js"></script>	1 <script src="full-screen-test.js"></script>

2 <script>	2 <script>

3 if (window.testRunner)	3 if (window.testRunner)

4 testRunner.dumpChildFramesAsText();	4 testRunner.dumpChildFramesAsText();

5	5

6 var waitingFor = 2;	6 var waitingFor = 2;

7 function runTest() {	7 function runTest() {

8 if (--waitingFor)	8 if (--waitingFor)

9 return;	9 return;

10 var frame = document.getElementById('frame');	10 var frame = document.getElementById('frame');

(...skipping 13 matching lines...) Expand all Loading...
24 if (testRunner)	24 if (testRunner)

25 testRunner.notifyDone();	25 testRunner.notifyDone();

26 }, 50);	26 }, 50);

27	27

28 frame.contentDocument.documentElement.webkitRequestFullScreen();	28 frame.contentDocument.documentElement.webkitRequestFullScreen();

29 });	29 });

30 }	30 }

31 </script>	31 </script>

32 <frameset rows="150,*">	32 <frameset rows="150,*">

33 <frame name="header" src="resources/not-allowed.html" webkitfullscreenallowe d onload="runTest()">	33 <frame name="header" src="resources/not-allowed.html" webkitfullscreenallowe d onload="runTest()">

34 <frame id="frame" name="frame" src="resources/inner.html" onload="runTest()" >	34 <frame id="frame" src="resources/inner.html" onload="runTest()">

35 </frameset>	35 </frameset>

OLD	NEW