LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html - Issue 196523007: Revert of id of iframe incorrectly sets window name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html

Issue 196523007: Revert of id of iframe incorrectly sets window name (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/images/exif-orientation-image-document.html ('k') | LayoutTests/fast/overflow/scrollRevealButton.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html

diff --git a/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html b/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html

index 03363293a06b401554d5c554adf6a29b45d697d2..313b7c13074512c58c41e46a38f92db5732aba7e 100644

--- a/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html

+++ b/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html

@@ -4,7 +4,7 @@

function runTest()

{

- window.frames["subframe"].location = 'data:text/html,<body onload="testRunner.notifyDone();"></body>';

+ document.getElementById("subframe").contentWindow.location = 'data:text/html,<body onload="testRunner.notifyDone();"></body>';

}

</script>

@@ -13,7 +13,7 @@

This test navigates an iframe while it's onload handler is still running.<br>

The iframe navigation should *not* result in a second back-history item being created for the top level navigation.<br>

-<iframe name="subframe" src="about:blank"></iframe><br>

+<iframe id="subframe" src="about:blank"></iframe><br>

</body>

« no previous file with comments | « LayoutTests/fast/images/exif-orientation-image-document.html ('k') | LayoutTests/fast/overflow/scrollRevealButton.html » ('j') | no next file with comments »