LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html - Issue 196523007: Revert of id of iframe incorrectly sets window name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html

Issue 196523007: Revert of id of iframe incorrectly sets window name (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/referrer-policy-redirect-link.html ('k') | LayoutTests/http/tests/security/srcdoc-inherits-referrer-for-forms.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html

diff --git a/LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html b/LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html

index 28a79fe08d993e34e933e920f9d1cc901839fb29..7058e650fb38efa4c97067a13a3cfae940f789ad 100644

--- a/LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html

+++ b/LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent.html

@@ -8,9 +8,9 @@

}

function test() {

- var testFrameWindow = window.frames['testframe'];

+ var test = document.getElementById('testframe');

try {

- var location = testFrameWindow.location.href;

+ var location = test.contentWindow.location.href;

} catch (e) {

alert("PASS: Cross-origin access to the Location object threw an exception.");

}

@@ -23,6 +23,6 @@

containing document shouldn't have script access to. This test passes if an

exception is thrown upon the access violation.</p>

- <iframe src="resources/blank.html" name="testframe" sandbox onload="test();"></iframe>

+ <iframe src="resources/blank.html" id="testframe" sandbox onload="test();"></iframe>

</body>

</html>