Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196413016: Move CommandLine to base namespace. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, viettrungluu+watch_chromium.org, tburkard+watch_chromium.org, nasko+codewatch_chromium.org, yoshiki+watch_chromium.org, dcheng, Dmitry Titov, rginda+watch_chromium.org, native-client-reviews_googlegroups.com, Ilya Sherman, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, chromoting-reviews_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, kalyank, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, jennb, creis+watch_chromium.org, ilevy-cc_chromium.org, fischman+watch_chromium.org, haitaol+watch_chromium.org, craigdh+watch_chromium.org, jianli, feature-media-reviews_chromium.org, bulach+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, klundberg+watch_chromium.org, darin (slow to review), jochen+watch_chromium.org, maniscalco+watch_chromium.org, davidben+watch_chromium.org, oshima+watch_chromium.org, gavinp+prer_chromium.org, tfarina, mcasas+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, eroman, robertshield, ben+ash_chromium.org, grt+watch_chromium.org, stgao, wjia+watch_chromium.org, mmenke, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move CommandLine to base namespace. Fix all forward-declares and header files referencing CommandLine. This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257514

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Fix Android #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -483 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M apps/app_load_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/launcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/shell/browser/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/shell/browser/shell_extensions_browser_client.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller.h View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/shell.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/command_line.h View 7 chunks +12 lines, -7 lines 0 comments Download
M base/command_line.cc View 1 2 10 chunks +14 lines, -11 lines 0 comments Download
M base/mac/launch_services_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process/launch.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/launcher/test_launcher.h View 2 chunks +1 line, -2 lines 0 comments Download
M base/test/launcher/test_results_tracker.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/test/multiprocess_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_delegate.h View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/background/background_contents_service.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/background/background_mode_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part_base.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_field_trials_mobile.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_base_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_configurator.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_controller.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/command_line_private/command_line_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/startup_helper.h View 3 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_installer_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 13 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/first_run/first_run.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/upgrade_util.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/invalidation/invalidation_service_util.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/io_thread.h View 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/jankometer.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/jankometer_android.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jankometer_mac.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_updater_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/test_license_server_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/wv_test_license_server_config.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/notifications/sync_notifier/chrome_notifier_service_factory.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_factory.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton.h View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/process_singleton_modal_dialog_lock.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_startup_lock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service_process/service_process_control.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_linux.h View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_test.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 8 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_ui_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/crash_keys.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/logging_chrome.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/service_process_util.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_posix.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/switch_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install_worker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_main.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/installer/setup/uninstall.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_app_host_operations.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/chrome_binaries_operations.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/chrome_browser_sxs_operations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_frame_operations.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/fake_product_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/install_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/installation_state.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_validator.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/installer/util/installer_state.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/product.h View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/installer/util/product_operations.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/installer/util/user_experiment.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/service/service_process.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/service/service_utility_process_host.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/automation/proxy_launcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/base/test_launcher_utils.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/chromedriver/capabilities.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_desktop_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/print_preview.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/switch_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/browser_perf_test.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 9 chunks +17 lines, -12 lines 0 comments Download
M chrome/test/ui/ui_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cloud_print/service/win/service_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_utils.h View 1 chunk +5 lines, -3 lines 0 comments Download
M components/nacl/browser/nacl_process_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/nacl/common/nacl_cmd_line.h View 1 chunk +8 lines, -4 lines 0 comments Download
M content/browser/android/child_process_launcher_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/child_process_launcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/child/runtime_features.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/sandbox_win.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/app/startup_helper_win.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/public/browser/browser_child_process_host.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M content/public/common/content_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/main_function_params.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/sandbox_init.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/browser_test_base.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/render_view_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_launcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.h View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/feature_switch.h View 3 chunks +5 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 3 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_util.h View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/shell/child_process.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/system/embedder/platform_channel_pair.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/test/python_utils.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/test/spawned_test_server/local_test_server.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M net/test/spawned_test_server/local_test_server.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/local_test_server_posix.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/test/spawned_test_server/local_test_server_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/win/host_service.h View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/win/launch_process_with_token.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/unprivileged_process_delegate.h View 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.h View 2 chunks +2 lines, -3 lines 0 comments Download
M skia/ext/image_operations_bench.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M sync/test/local_sync_test_server.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/local_sync_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 2 chunks +3 lines, -1 line 0 comments Download
M tools/android/common/daemon.h View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/gn/setup.h View 3 chunks +7 lines, -4 lines 0 comments Download
M tools/gn/trace.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_util.h View 2 chunks +6 lines, -3 lines 0 comments Download
M win8/delegate_execute/command_execute_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_operation.h View 2 chunks +3 lines, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 9 months ago (2014-03-14 22:54:36 UTC) #1
brettw
6 years, 9 months ago (2014-03-17 23:07:23 UTC) #2
Message was sent while issue was closed. 
Committed patchset #7 manually as r257514 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698