Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9098)

Unified Diff: chrome/installer/util/product_operations.h

Issue 196413016: Move CommandLine to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/product.h ('k') | chrome/installer/util/user_experiment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/product_operations.h
diff --git a/chrome/installer/util/product_operations.h b/chrome/installer/util/product_operations.h
index bb6c208968c4093f12b0d3e4d387cd0ab22d1f9a..d84a1b9e893d975404d5ea47f55daec3c0915816 100644
--- a/chrome/installer/util/product_operations.h
+++ b/chrome/installer/util/product_operations.h
@@ -15,7 +15,10 @@
#include "chrome/installer/util/util_constants.h"
class BrowserDistribution;
+
+namespace base {
class CommandLine;
+}
namespace installer {
@@ -35,7 +38,7 @@ class ProductOperations {
std::set<base::string16>* options) const = 0;
// Reads product-specific options from |command|, adding them to |options|.
- virtual void ReadOptions(const CommandLine& command,
+ virtual void ReadOptions(const base::CommandLine& command,
std::set<base::string16>* options) const = 0;
// A key-file is a file such as a DLL on Windows that is expected to be in use
@@ -59,11 +62,11 @@ class ProductOperations {
// required for product-specific uninstall commands, but are of use for any
// invocation of setup.exe for the product.
virtual void AppendProductFlags(const std::set<base::string16>& options,
- CommandLine* cmd_line) const = 0;
+ base::CommandLine* cmd_line) const = 0;
// Given a command line, appends the set of product-specific rename flags.
virtual void AppendRenameFlags(const std::set<base::string16>& options,
- CommandLine* cmd_line) const = 0;
+ base::CommandLine* cmd_line) const = 0;
// Adds or removes product-specific flags in |channel_info|. Returns true if
// |channel_info| is modified.
« no previous file with comments | « chrome/installer/util/product.h ('k') | chrome/installer/util/user_experiment.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698