Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: chrome/browser/io_thread.h

Issue 196413016: Move CommandLine to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/invalidation/invalidation_service_util.h ('k') | chrome/browser/jankometer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.h
diff --git a/chrome/browser/io_thread.h b/chrome/browser/io_thread.h
index a41d83fdb5dc23a33ebbb77b9f16f944919c6b01..40bee1bff643e5f5616220f20d89f7ec19ccaf63 100644
--- a/chrome/browser/io_thread.h
+++ b/chrome/browser/io_thread.h
@@ -22,12 +22,15 @@
#include "net/socket/next_proto.h"
class ChromeNetLog;
-class CommandLine;
class PrefProxyConfigTracker;
class PrefService;
class PrefRegistrySimple;
class SystemURLRequestContextGetter;
+namespace base {
+class CommandLine;
+}
+
namespace chrome_browser_net {
class DnsProbeService;
class HttpPipeliningCompatibilityClient;
@@ -222,7 +225,7 @@ class IOThread : public content::BrowserThreadDelegate {
virtual void InitAsync() OVERRIDE;
virtual void CleanUp() OVERRIDE;
- void InitializeNetworkOptions(const CommandLine& parsed_command_line);
+ void InitializeNetworkOptions(const base::CommandLine& parsed_command_line);
// Enable SPDY with the given mode, which may contain the following:
//
@@ -263,41 +266,41 @@ class IOThread : public content::BrowserThreadDelegate {
// Configures QUIC options based on the flags in |command_line| as
// well as the QUIC field trial group.
- void ConfigureQuic(const CommandLine& command_line);
+ void ConfigureQuic(const base::CommandLine& command_line);
// Returns true if QUIC should be enabled, either as a result
// of a field trial or a command line flag.
- bool ShouldEnableQuic(const CommandLine& command_line,
+ bool ShouldEnableQuic(const base::CommandLine& command_line,
base::StringPiece quic_trial_group);
// Returns true if HTTPS over QUIC should be enabled, either as a result
// of a field trial or a command line flag.
- bool ShouldEnableQuicHttps(const CommandLine& command_line,
+ bool ShouldEnableQuicHttps(const base::CommandLine& command_line,
base::StringPiece quic_trial_group);
// Returns true if the selection of the ephemeral port in bind() should be
// performed by Chromium, and false if the OS should select the port. The OS
// option is used to prevent Windows from posting a security security warning
// dialog.
- bool ShouldEnableQuicPortSelection(const CommandLine& command_line);
+ bool ShouldEnableQuicPortSelection(const base::CommandLine& command_line);
// Returns true if QUIC packet pacing should be negotiated during the
// QUIC handshake.
- bool ShouldEnableQuicPacing(const CommandLine& command_line,
+ bool ShouldEnableQuicPacing(const base::CommandLine& command_line,
base::StringPiece quic_trial_group);
// Returns true if Chromium should persist QUIC server config information to
// disk cache.
- bool ShouldEnableQuicPersistServerInfo(const CommandLine& command_line);
+ bool ShouldEnableQuicPersistServerInfo(const base::CommandLine& command_line);
// Returns the maximum length for QUIC packets, based on any flags in
// |command_line| or the field trial. Returns 0 if there is an error
// parsing any of the options, or if the default value should be used.
- size_t GetQuicMaxPacketLength(const CommandLine& command_line,
+ size_t GetQuicMaxPacketLength(const base::CommandLine& command_line,
base::StringPiece quic_trial_group);
// Returns the quic versions specified by any flags in |command_line|.
- net::QuicVersion GetQuicVersion(const CommandLine& command_line);
+ net::QuicVersion GetQuicVersion(const base::CommandLine& command_line);
// The NetLog is owned by the browser process, to allow logging from other
// threads during shutdown, but is used most frequently on the IOThread.
« no previous file with comments | « chrome/browser/invalidation/invalidation_service_util.h ('k') | chrome/browser/jankometer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698