Report media error if PlayOutputBuffer failed

Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG=585978, 606061
Committed: https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df
Cr-Commit-Position: refs/heads/master@{#393124}

[Tima Vaisburd, 2016-05-10 22:17:51]

Description was changed from

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

BUG=585978, 606061
==========

to

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For
MediaCodecPlayer the decoder's method Render() now returns bool.

BUG=585978, 606061
==========

[Tima Vaisburd, 2016-05-10 22:18:08]

Description was changed from

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For
MediaCodecPlayer the decoder's method Render() now returns bool.

BUG=585978, 606061
==========

to

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG=585978, 606061
==========

[Tima Vaisburd, 2016-05-10 22:18:56]

timav@chromium.org changed reviewers:
+ qinmin@chromium.org, watk@chromium.org

[Tima Vaisburd, 2016-05-10 22:18:57]

PTAL (not tested yet).

[qinmin, 2016-05-10 22:43:23]

https://codereview.chromium.org/1963343002/diff/1/media/base/android/audio_de...
File media/base/android/audio_decoder_job.cc (right):

https://codereview.chromium.org/1963343002/diff/1/media/base/android/audio_de...
media/base/android/audio_decoder_job.cc:118: status =
(static_cast<AudioCodecBridge*>(media_codec_bridge_.get()))
The input status could be MEDIA_CODEC_OUTPUT_FORMAT_CHANGED or
MEDIA_CODEC_OUTPUT_END_OF_STREAM, which has a special meaning to the player. And
now we override it with Media_Codec_OK, that's will break those special cases.

[Tima Vaisburd, 2016-05-10 23:19:56]

https://codereview.chromium.org/1963343002/diff/1/media/base/android/audio_de...
File media/base/android/audio_decoder_job.cc (right):

https://codereview.chromium.org/1963343002/diff/1/media/base/android/audio_de...
media/base/android/audio_decoder_job.cc:118: status =
(static_cast<AudioCodecBridge*>(media_codec_bridge_.get()))
On 2016/05/10 22:43:23, qinmin wrote:
> The input status could be MEDIA_CODEC_OUTPUT_FORMAT_CHANGED or
> MEDIA_CODEC_OUTPUT_END_OF_STREAM, which has a special meaning to the player.
And
> now we override it with Media_Codec_OK, that's will break those special cases.

Yes, I see it now. Now I override the status only in case of an error. Also
tested a regular playback and ran existing unit tests.

[watk, 2016-05-10 23:35:53]

lgtm

[Tima Vaisburd, 2016-05-11 18:14:24]

On 2016/05/10 23:35:53, watk wrote:
> lgtm

Min, would you like to add more comments?

[qinmin, 2016-05-11 20:58:29]

lgtm % nit

https://codereview.chromium.org/1963343002/diff/20001/media/base/android/audi...
File media/base/android/audio_decoder_job.cc (right):

https://codereview.chromium.org/1963343002/diff/20001/media/base/android/audi...
media/base/android/audio_decoder_job.cc:115: const bool postpone = false;
nit:I would get rid of this variable and just use false below.

[Tima Vaisburd, 2016-05-11 22:24:33]

https://codereview.chromium.org/1963343002/diff/20001/media/base/android/audi...
File media/base/android/audio_decoder_job.cc (right):

https://codereview.chromium.org/1963343002/diff/20001/media/base/android/audi...
media/base/android/audio_decoder_job.cc:115: const bool postpone = false;
On 2016/05/11 20:58:29, qinmin wrote:
> nit:I would get rid of this variable and just use false below.

Done.

[Tima Vaisburd, 2016-05-11 22:24:42]

The CQ bit was checked by timav@chromium.org

[Tima Vaisburd, 2016-05-11 22:24:43]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org,
qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/1963343002/#ps40001
(title: "Addressed Min's comment")

[commit-bot: I haz the power, 2016-05-11 22:25:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963343002/40001

[commit-bot: I haz the power, 2016-05-12 00:51:13]

Description was changed from

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG=585978, 606061
==========

to

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG=585978, 606061
==========

[commit-bot: I haz the power, 2016-05-12 00:51:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 00:52:51]

Description was changed from

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG=585978, 606061
==========

to

==========
Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG=585978, 606061

Committed: https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df
Cr-Commit-Position: refs/heads/master@{#393124}
==========

[commit-bot: I haz the power, 2016-05-12 00:52:52]

Patchset 3 (id:??) landed as
https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df
Cr-Commit-Position: refs/heads/master@{#393124}