media/base/android/audio_media_codec_decoder.h - Issue 1963343002: Report media error if PlayOutputBuffer failed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/audio_media_codec_decoder.h

Issue 1963343002: Report media error if PlayOutputBuffer failed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Min's comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/android/audio_media_codec_decoder.h

diff --git a/media/base/android/audio_media_codec_decoder.h b/media/base/android/audio_media_codec_decoder.h

index 8a6eb6daad3b2eb81a554738ceca5852b78b5ce8..6d7a8249a22bd3cf475a48f4c22c53b9c0dfc810 100644

--- a/media/base/android/audio_media_codec_decoder.h

+++ b/media/base/android/audio_media_codec_decoder.h

@@ -52,7 +52,7 @@ class AudioMediaCodecDecoder : public MediaCodecDecoder {

bool IsCodecReconfigureNeeded(const DemuxerConfigs& next) const override;

ConfigStatus ConfigureInternal(jobject media_crypto) override;

bool OnOutputFormatChanged() override;

- void Render(int buffer_index,

+ bool Render(int buffer_index,

size_t offset,

size_t size,

RenderMode render_mode,