Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: media/base/android/media_decoder_job.h

Issue 1963343002: Report media error if PlayOutputBuffer failed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Min's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_codec_decoder.cc ('k') | media/base/android/media_decoder_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_decoder_job.h
diff --git a/media/base/android/media_decoder_job.h b/media/base/android/media_decoder_job.h
index 46221814c198657809ec1f400bccda4bd2da59bf..4facf4873f32794e47dddfdcb1a7719de00e4a30 100644
--- a/media/base/android/media_decoder_job.h
+++ b/media/base/android/media_decoder_job.h
@@ -51,13 +51,6 @@ class MediaDecoderJob {
// case.
typedef base::Callback<void(MediaCodecStatus, bool, base::TimeDelta,
base::TimeDelta)> DecoderCallback;
- // Callback when a decoder job finishes releasing the output buffer.
- // Args: whether the frame is a late frame, current presentation time, max
- // presentation time.
- // If the current presentation time is equal to kNoTimestamp(), the callback
- // target should ignore the timestamps provided and whether it is late.
- typedef base::Callback<void(bool, base::TimeDelta, base::TimeDelta)>
- ReleaseOutputCompletionCallback;
virtual ~MediaDecoderJob();
@@ -137,7 +130,8 @@ class MediaDecoderJob {
bool render_output,
bool is_late_frame,
base::TimeDelta current_presentation_timestamp,
- const ReleaseOutputCompletionCallback& callback) = 0;
+ MediaCodecStatus status,
+ const DecoderCallback& callback) = 0;
// Returns true if the "time to render" needs to be computed for frames in
// this decoder job.
« no previous file with comments | « media/base/android/media_codec_decoder.cc ('k') | media/base/android/media_decoder_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698