Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: media/base/android/media_decoder_job.cc

Issue 1963343002: Report media error if PlayOutputBuffer failed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Min's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_decoder_job.h ('k') | media/base/android/sdk_media_codec_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_decoder_job.cc
diff --git a/media/base/android/media_decoder_job.cc b/media/base/android/media_decoder_job.cc
index 0e036870bb96810ada4f73200e65bd0d3e8fb238..ad9b637f833ca8e49de742417a945aa7c2be9037 100644
--- a/media/base/android/media_decoder_job.cc
+++ b/media/base/android/media_decoder_job.cc
@@ -487,12 +487,11 @@ void MediaDecoderJob::DecodeInternal(
if (time_to_render > base::TimeDelta()) {
decoder_task_runner_->PostDelayedTask(
- FROM_HERE,
- base::Bind(&MediaDecoderJob::ReleaseOutputBuffer,
- base::Unretained(this), buffer_index, offset, size,
- render_output,
- false, // this is not a late frame
- presentation_timestamp, base::Bind(callback, status)),
+ FROM_HERE, base::Bind(&MediaDecoderJob::ReleaseOutputBuffer,
+ base::Unretained(this), buffer_index, offset,
+ size, render_output,
+ false, // this is not a late frame
+ presentation_timestamp, status, callback),
time_to_render);
return;
}
@@ -511,12 +510,9 @@ void MediaDecoderJob::DecodeInternal(
presentation_timestamp = kNoTimestamp();
}
- ReleaseOutputCompletionCallback completion_callback = base::Bind(
- callback, status);
-
const bool is_late_frame = (time_to_render < base::TimeDelta());
ReleaseOutputBuffer(buffer_index, offset, size, render_output, is_late_frame,
- presentation_timestamp, completion_callback);
+ presentation_timestamp, status, callback);
}
void MediaDecoderJob::OnDecodeCompleted(
« no previous file with comments | « media/base/android/media_decoder_job.h ('k') | media/base/android/sdk_media_codec_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698