Issue 19616008: [chromedriver] Allow commands to be async.

Issue 19616008: [chromedriver] Allow commands to be async. (Closed)

Created:
7 years, 5 months ago by kkania

Modified:
7 years, 5 months ago

Reviewers:
chrisgao (Use stgao instead)

CC:
chromium-reviews, kkania, frankf

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Allow commands to be async. Run all commands on command thread. This is in preparation for switching from mongoose to net::HttpServer. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213285

Patch Set 1 #

Patch Set 2 : fix #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+991 lines, -935 lines)			Patch
M	chrome/chrome_tests.gypi	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/test/chromedriver/README.txt	View		3 chunks	+25 lines, -16 lines	0 comments	Download
M	chrome/test/chromedriver/alert_commands.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/adb_impl.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/adb_impl.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/test/chromedriver/command.h	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	chrome/test/chromedriver/commands.h	View		2 chunks	+29 lines, -21 lines	0 comments	Download
M	chrome/test/chromedriver/commands.cc	View	1	4 chunks	+185 lines, -58 lines	0 comments	Download
M	chrome/test/chromedriver/commands_unittest.cc	View		3 chunks	+148 lines, -102 lines	0 comments	Download
D	chrome/test/chromedriver/fake_session_accessor.h	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	chrome/test/chromedriver/fake_session_accessor.cc	View		1 chunk	+0 lines, -28 lines	0 comments	Download
M	chrome/test/chromedriver/server/chromedriver_server.cc	View		7 chunks	+60 lines, -16 lines	0 comments	Download
M	chrome/test/chromedriver/server/http_handler.h	View		3 chunks	+29 lines, -10 lines	0 comments	Download
M	chrome/test/chromedriver/server/http_handler.cc	View		7 chunks	+371 lines, -237 lines	0 comments	Download
M	chrome/test/chromedriver/server/http_handler_unittest.cc	View		8 chunks	+18 lines, -13 lines	0 comments	Download
M	chrome/test/chromedriver/session.h	View		3 chunks	+1 line, -32 lines	0 comments	Download
M	chrome/test/chromedriver/session.cc	View		3 chunks	+2 lines, -16 lines	0 comments	Download
M	chrome/test/chromedriver/session_commands.h	View		3 chunks	+6 lines, -15 lines	0 comments	Download
M	chrome/test/chromedriver/session_commands.cc	View		4 chunks	+11 lines, -44 lines	0 comments	Download
M	chrome/test/chromedriver/session_commands_unittest.cc	View		1 chunk	+73 lines, -81 lines	0 comments	Download
D	chrome/test/chromedriver/session_map.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
A	chrome/test/chromedriver/session_thread_map.h	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/session_unittest.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/test/chromedriver/synchronized_map.h	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/test/chromedriver/synchronized_map_unittest.cc	View		1 chunk	+0 lines, -78 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kkania

prev version of this patch broke winx64 builder patch 1 - unrevert patch 2 - ...

7 years, 5 months ago (2013-07-23 20:53:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/19616008/1026

7 years, 5 months ago (2013-07-23 21:39:20 UTC) #3

Message was sent while issue was closed.

Change committed as 213285

Expand Messages | Collapse Messages