Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: chrome/test/chromedriver/session_commands.h

Issue 19616008: [chromedriver] Allow commands to be async. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/session.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/session_commands.h
diff --git a/chrome/test/chromedriver/session_commands.h b/chrome/test/chromedriver/session_commands.h
index 23af1567609662a102083cd85a2017ac4fdf4e51..618f124a0cdd258308f124e342577d3872c10632 100644
--- a/chrome/test/chromedriver/session_commands.h
+++ b/chrome/test/chromedriver/session_commands.h
@@ -9,7 +9,8 @@
#include "base/callback_forward.h"
#include "base/memory/scoped_ptr.h"
-#include "chrome/test/chromedriver/session_map.h"
+#include "chrome/test/chromedriver/command.h"
+#include "chrome/test/chromedriver/session_thread_map.h"
namespace base {
class DictionaryValue;
@@ -19,24 +20,15 @@ class Value;
struct Session;
class Status;
-typedef base::Callback<Status(
+// Quits a session.
+Status ExecuteQuit(
+ bool allow_detach,
Session* session,
- const base::DictionaryValue&,
- scoped_ptr<base::Value>*)> SessionCommand;
-
-// Executes a given session command, after acquiring access to the appropriate
-// session.
-Status ExecuteSessionCommand(
- SessionMap* session_map,
- const SessionCommand& command,
const base::DictionaryValue& params,
- const std::string& session_id,
- scoped_ptr<base::Value>* out_value,
- std::string* out_session_id);
+ scoped_ptr<base::Value>* value);
// Gets the capabilities of a particular session.
Status ExecuteGetSessionCapabilities(
- SessionMap* session_map,
Session* session,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value);
@@ -49,7 +41,6 @@ Status ExecuteGetCurrentWindowHandle(
// Close the target window.
Status ExecuteClose(
- SessionMap* session_map,
Session* session,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value);
« no previous file with comments | « chrome/test/chromedriver/session.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698