Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10560)

Unified Diff: chrome/test/chromedriver/session.cc

Issue 19616008: [chromedriver] Allow commands to be async. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/session.h ('k') | chrome/test/chromedriver/session_commands.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/session.cc
diff --git a/chrome/test/chromedriver/session.cc b/chrome/test/chromedriver/session.cc
index 51a409db1e5a96cff0cc78a538cad210c9850c50..ea6da2cac1bc686daec96ce43ed8ca6d7b775b08 100644
--- a/chrome/test/chromedriver/session.cc
+++ b/chrome/test/chromedriver/session.cc
@@ -24,7 +24,7 @@ const int Session::kDefaultPageLoadTimeoutMs = 5 * 60 * 1000;
Session::Session(const std::string& id)
: id(id),
- thread(("SessionThread_" + id).c_str()),
+ quit(false),
detach(false),
sticky_modifiers(0),
mouse_position(0, 0),
@@ -35,7 +35,7 @@ Session::Session(const std::string& id)
Session::Session(const std::string& id, scoped_ptr<Chrome> chrome)
: id(id),
- thread(("SessionThread_" + id).c_str()),
+ quit(false),
detach(false),
chrome(chrome.Pass()),
sticky_modifiers(0),
@@ -96,17 +96,3 @@ scoped_ptr<base::DictionaryValue> Session::CreateCapabilities() {
caps->SetBoolean("nativeEvents", true);
return caps.Pass();
}
-
-SessionAccessorImpl::SessionAccessorImpl(scoped_ptr<Session> session)
- : session_(session.Pass()) {}
-
-Session* SessionAccessorImpl::Access(scoped_ptr<base::AutoLock>* lock) {
- lock->reset(new base::AutoLock(session_lock_));
- return session_.get();
-}
-
-void SessionAccessorImpl::DeleteSession() {
- session_.reset();
-}
-
-SessionAccessorImpl::~SessionAccessorImpl() {}
« no previous file with comments | « chrome/test/chromedriver/session.h ('k') | chrome/test/chromedriver/session_commands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698